Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vuetransfomer): fix unknown asset language for vue scripts/templa… #7056

Merged
merged 6 commits into from Oct 15, 2021

Conversation

RuyiLi
Copy link
Contributor

@RuyiLi RuyiLi commented Oct 12, 2021

…tes/styles

↪️ Pull Request

Address an issue where attempting to load a script/template/style from another file would fail due to VueTransformer not being able to detect the language from the file name.

💻 Examples

#6546

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@height
Copy link

height bot commented Oct 12, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@RuyiLi RuyiLi closed this Oct 12, 2021
fix(vuetransfomer): fix unknown asset language for vue scripts/templa…
@101arrowz
Copy link
Member

101arrowz commented Oct 14, 2021

Not sure why this was closed but I accidentally recreated this in #7069. @RuyiLi feel free to re-open this if you want.

@RuyiLi RuyiLi reopened this Oct 14, 2021
@DeMoorJasper
Copy link
Member

Could you add a test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants