Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix src tag for Vue SFCs #7069

Closed
wants to merge 1 commit into from
Closed

Conversation

101arrowz
Copy link
Member

↪️ Pull Request

Fixes the src tag in Vue SFCs, which previously didn't work because the type was detected as .js instead of js.

💻 Examples

App.vue:

<script src="./other.tsx" />

other.tsx:

import { defineComponent, h } from 'vue'

export default defineComponent({
  render() {
    return <h1>Hi there!</h1>
  }
})

Just noticed this while testing out the v2.0.0 stable release (Congrats! 🎉) I'd prefer to make a PR for tests later, though a regression test could be nice.

@height
Copy link

height bot commented Oct 14, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@DeMoorJasper
Copy link
Member

Could you add a test for this?

@101arrowz
Copy link
Member Author

I think this can be moved back to #7056, which already did the same thing.

@101arrowz 101arrowz closed this Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants