Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semver version range #7334

Merged
merged 2 commits into from Nov 21, 2021
Merged

Fix semver version range #7334

merged 2 commits into from Nov 21, 2021

Conversation

mischnic
Copy link
Member

The JS transformer was using semver.minVersion which was introduced in semver 5.7 while the semver dependency range was only ^5.4.1.

I've bumped this range across all packages because to prevent this from happening in the future (using semver.minVersion but forgetting to bump the range).

#6720 (comment)

@height
Copy link

height bot commented Nov 19, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic mischnic mentioned this pull request Nov 19, 2021
Closed
@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.53s +192.00ms ⚠️
Cached 321.00ms -1.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 760.00ms +57.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 761.00ms +57.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 761.00ms +58.00ms ⚠️
dist/legacy/index.96016b08.js 1.59kb +0.00b 1.08s +71.00ms ⚠️
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 1.08s +71.00ms ⚠️
dist/modern/index.6be20f01.js 1.13kb +0.00b 1.08s +72.00ms ⚠️
dist/legacy/index.c1bc86aa.css 94.00b +0.00b 1.43s +75.00ms ⚠️
dist/modern/index.57a95cbe.css 94.00b +0.00b 1.43s +75.00ms ⚠️

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 11.77s -302.00ms
Cached 491.00ms +24.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 5.40s -1.16s 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.24m +539.00ms
Cached 1.60s +58.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/EmojiPickerComponent.922af3e4.js 147.13kb +0.00b 34.41s +11.82s ⚠️
dist/esm.f1a592e5.js 33.15kb +0.00b 34.41s +11.82s ⚠️
dist/DatePicker.f2994e45.js 22.98kb +0.00b 34.41s +11.82s ⚠️
dist/js.660b75db.js 17.25kb +0.00b 56.05s +13.94s ⚠️
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 56.05s +13.94s ⚠️
dist/feedback.c7e69064.js 1.77kb +0.00b 34.41s +11.82s ⚠️
dist/workerHasher.3639b1f9.js 1.63kb +0.00b 34.41s +11.82s ⚠️
dist/heading6.a693146e.js 1.51kb +0.00b 34.41s +11.82s ⚠️
dist/heading5.8bfafe21.js 1.38kb +0.00b 34.41s +11.82s ⚠️
dist/expand.a44d10fe.js 1.29kb +0.00b 34.41s +11.82s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.0bcf7f7d.js 1.78mb +0.00b 22.19s +1.16s ⚠️
dist/pdfRenderer.dccadd23.js 1.11mb +0.00b 59.56s +3.69s ⚠️
dist/index.c8c11eb0.js 693.84kb +0.00b 59.52s +3.69s ⚠️
dist/editorView.124f5fc0.js 594.92kb +0.00b 58.97s +3.64s ⚠️
dist/popup.64bc9a82.js 209.67kb +0.00b 58.96s +3.63s ⚠️
dist/EmojiPickerComponent.922af3e4.js 147.13kb +0.00b 36.40s +1.86s ⚠️
dist/index.6815e9d4.js 145.62kb +0.00b 59.52s +3.69s ⚠️
dist/Toolbar.1af0e801.js 107.23kb +0.00b 58.97s +3.64s ⚠️
dist/media-viewer.d950776f.js 74.93kb +0.00b 59.56s +3.69s ⚠️
dist/card.8ef34b4f.js 62.67kb +0.00b 59.51s +3.69s ⚠️
dist/card.41e5c61a.js 60.71kb +0.00b 59.57s +3.69s ⚠️
dist/Modal.cd71eaf3.js 45.33kb +0.00b 58.96s +3.63s ⚠️
dist/component.5b4e4410.js 37.35kb +0.00b 22.19s +1.16s ⚠️
dist/esm.f1a592e5.js 33.15kb +0.00b 36.40s +1.86s ⚠️
dist/component.741edbc5.js 24.94kb +0.00b 22.19s +1.16s ⚠️
dist/DatePicker.f2994e45.js 22.98kb +0.00b 36.40s +1.86s ⚠️
dist/js.660b75db.js 17.25kb +0.00b 58.97s +3.64s ⚠️
dist/ui.5d3f7adc.js 14.94kb +0.00b 58.97s +3.64s ⚠️
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 58.97s +3.64s ⚠️
dist/dropzone.39132d0c.js 12.16kb +0.00b 58.97s +3.63s ⚠️
dist/workerHasher.11b8f69d.js 11.83kb +0.00b 44.60s +2.83s ⚠️
dist/component.598bf511.js 6.83kb +0.00b 21.95s +1.18s ⚠️
dist/index.b54ac00e.js 6.18kb +0.00b 59.57s +3.69s ⚠️
dist/card.26823fa1.js 5.77kb +0.00b 59.51s +3.69s ⚠️
dist/media-viewer.a19e03bf.js 4.50kb +0.00b 44.59s +2.83s ⚠️
dist/media-viewer.21624a99.js 3.93kb +0.00b 44.59s +2.84s ⚠️
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 58.97s +3.64s ⚠️
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 58.97s +3.64s ⚠️
dist/index.c6306681.css 3.47kb +0.00b 59.85s +3.73s ⚠️
dist/dropzone.55bef257.js 3.29kb +0.00b 58.96s +3.63s ⚠️
dist/Modal.ecafad9e.js 3.15kb +0.00b 59.51s +3.69s ⚠️
dist/clipboard.df70240c.js 2.93kb +0.00b 58.97s +3.64s ⚠️
dist/16.4e6ce5ae.js 2.35kb +0.00b 22.19s +1.16s ⚠️
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 58.97s +3.64s ⚠️
dist/card.47672f0e.js 2.04kb +0.00b 44.59s +2.84s ⚠️
dist/date.ada90b9d.js 1.87kb +0.00b 22.19s +1.16s ⚠️
dist/feedback.c7e69064.js 1.77kb +0.00b 36.39s +1.86s ⚠️
dist/16.f9bcc218.js 1.74kb +0.00b 21.95s +1.18s ⚠️
dist/browser.4e039ed7.js 1.69kb +0.00b 58.97s +3.64s ⚠️
dist/16.8cacdd41.js 1.67kb +0.00b 21.95s +1.18s ⚠️
dist/workerHasher.3639b1f9.js 1.63kb +0.00b 36.40s +1.86s ⚠️
dist/workerHasher.14be1ebc.js 1.63kb +0.00b 59.56s +3.69s ⚠️
dist/code.00826c30.js 1.51kb +0.00b 22.19s +1.16s ⚠️
dist/heading6.a693146e.js 1.51kb +0.00b 36.39s +1.85s ⚠️
dist/16.3ea64ad5.js 1.39kb +0.00b 21.95s +1.18s ⚠️
dist/heading5.8bfafe21.js 1.38kb +0.00b 36.39s +1.85s ⚠️
dist/16.dde66fb5.js 1.34kb +0.00b 21.95s +1.18s ⚠️
dist/16.17fccf53.js 1.34kb +0.00b 21.95s +1.18s ⚠️
dist/16.e572fbc0.js 1.32kb +0.00b 21.95s +1.18s ⚠️
dist/16.82436cab.js 1.32kb +0.00b 21.95s +1.18s ⚠️
dist/expand.a44d10fe.js 1.29kb +0.00b 36.40s +1.86s ⚠️
dist/16.bbe3d65c.js 1.28kb +0.00b 21.95s +1.18s ⚠️
dist/16.da4ba1b5.js 1.24kb +0.00b 21.95s +1.18s ⚠️
dist/16.5076785a.js 1.21kb +0.00b 21.95s +1.18s ⚠️
dist/16.b2ed99cf.js 1.20kb +0.00b 21.95s +1.18s ⚠️
dist/16.7d56994f.js 1.19kb +0.00b 21.95s +1.18s ⚠️
dist/Modal.ca6d4d94.js 1.16kb +0.00b 44.60s +2.83s ⚠️
dist/16.4788b572.js 1.15kb +0.00b 21.95s +1.18s ⚠️
dist/16.f98e3014.js 1.15kb +0.00b 21.95s +1.18s ⚠️
dist/16.10f72c3a.js 1.14kb +0.00b 21.95s +1.18s ⚠️
dist/16.d0a606ba.js 1.14kb +0.00b 21.95s +1.18s ⚠️
dist/16.75f3718c.js 1.14kb +0.00b 21.95s +1.18s ⚠️
dist/action.0ca21388.js 1.14kb +0.00b 22.19s +1.16s ⚠️
dist/16.a1253273.js 1.14kb +0.00b 21.95s +1.18s ⚠️
dist/component.6377d10b.js 1.13kb +0.00b 22.19s +1.16s ⚠️
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 58.97s +3.63s ⚠️
dist/16.70992eab.js 1.10kb +0.00b 21.95s +1.18s ⚠️
dist/16.dbb3595d.js 1.06kb +0.00b 21.95s +1.18s ⚠️
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 58.96s +3.63s ⚠️
dist/media-viewer-analytics-error-boundary.c928a889.js 966.00b +0.00b 59.56s +3.69s ⚠️
dist/media-card-analytics-error-boundary.30f51dac.js 962.00b +0.00b 59.51s +3.69s ⚠️
dist/media-card-analytics-error-boundary.6e65cc90.js 962.00b +0.00b 59.57s +3.69s ⚠️
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 58.97s +3.64s ⚠️
dist/simpleHasher.57fb325c.js 643.00b +0.00b 59.56s +3.69s ⚠️
dist/index.html 386.00b +0.00b 59.68s +3.70s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 7.62s -361.00ms
Cached 335.00ms -57.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.68kb +0.00b 5.74s -405.00ms 🚀

Click here to view a detailed benchmark overview.

@ZackMattor
Copy link

I hit this today too 👍

npm i semver@5.7

☝️ fixed it for me

ZackMattor added a commit to ZackMattor/tis-client that referenced this pull request Nov 20, 2021
@ZackMattor
Bumping Semver... parcel-bundler/parcel#7334
af2d521
@DeMoorJasper DeMoorJasper merged commit 1069398 into v2 Nov 21, 2021
@DeMoorJasper DeMoorJasper deleted the fix-semver-range branch November 21, 2021 09:42
lettertwo added a commit that referenced this pull request Nov 22, 2021
@lettertwo
Merge branch 'v2' into lettertwo/cache-large-blob
88b1e22 
* upstream/v2:
  Fix `semver` version range (#7334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeMoorJasper DeMoorJasper DeMoorJasper approved these changes

@devongovett devongovett Awaiting requested review from devongovett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mischnic @parcel-benchmark @ZackMattor @DeMoorJasper