Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for errorRecovery option in @parcel/transformer-css #8352

Merged
merged 4 commits into from Aug 1, 2022
Merged

Add support for errorRecovery option in @parcel/transformer-css #8352

merged 4 commits into from Aug 1, 2022
+83 −56

Conversation

devongovett
Copy link
Member

When enabled in the config in package.json, Parcel CSS will skip over invalid rules and declarations and emit warnings instead.

mischnic
mischnic approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@mischnic mischnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated: We probably want to validate the css transformer config with a schema at some point.

@parcel-benchmark
Copy link

parcel-benchmark commented Jul 31, 2022 •
edited

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.47s -33.00ms
Cached 346.00ms +2.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/modern/index.html 749.00b +0.00b 514.00ms -26.00ms 🚀

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 9.52s -134.00ms
Cached 473.00ms -6.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.70m -1.23s
Cached 2.74s +12.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/esm.8d173455.js 61.97kb +0.00b 1.27m +33.96s ⚠️
dist/workerHasher.e50d242f.js 1.72kb +0.00b 1.27m +33.96s ⚠️
dist/16.1969624f.js 1.08kb +0.00b 41.17s +3.05s ⚠️
dist/index.html 240.00b +0.00b 1.27m +39.33s ⚠️

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.97s -107.00ms
Cached 291.00ms +11.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 9012616 into v2 Aug 1, 2022
@devongovett devongovett deleted the css-error-recovery branch August 1, 2022 00:58
peterkeating added a commit to EtchUK/Etch.OrchardCore.ThemeBoilerplate that referenced this pull request Oct 5, 2022
@peterkeating
Switch from webpack to Parcel
fb5d720 
- Removed all webpack related configurations and dependencies
- Add parcel as dependency
- Moved static imagery to wwwroot as it's not longer moved as part of
the build process unless it's referenced directly in the CSS/TypeScript
- Needed to use `errorRecovery` option due to lightgallery using out of
date CSS techniques for clearfix - parcel-bundler/parcel#8352
- Removed content hashing using custom namer due to fonts being
preloaded in HTML, thus the name can't be changed for each build
- Rename output folders/filenames to match other team's approach
peterkeating added a commit to EtchUK/Etch.OrchardCore.ThemeBoilerplate that referenced this pull request Oct 6, 2022
@peterkeating
Switch from webpack to Parcel
003220f 
- Removed all webpack related configurations and dependencies
- Add parcel as dependency
- Moved static imagery to wwwroot as it's not longer moved as part of
the build process unless it's referenced directly in the CSS/TypeScript
- Needed to use `errorRecovery` option due to lightgallery using out of
date CSS techniques for clearfix - parcel-bundler/parcel#8352
- Removed content hashing using custom namer due to fonts being
preloaded in HTML, thus the name can't be changed for each build
- Rename output folders/filenames to match other team's approach
- Add linting via eslint & stylelint
- Perform linting & prettier via pre-commit git hook
peterkeating added a commit to EtchUK/Etch.OrchardCore.ThemeBoilerplate that referenced this pull request Oct 17, 2022
@peterkeating
Switch from webpack to Parcel
6777e63 
- Removed all webpack related configurations and dependencies
- Add parcel as dependency
- Moved static imagery to wwwroot as it's not longer moved as part of
the build process unless it's referenced directly in the CSS/TypeScript
- Needed to use `errorRecovery` option due to lightgallery using out of
date CSS techniques for clearfix - parcel-bundler/parcel#8352
- Removed content hashing using custom namer due to fonts being
preloaded in HTML, thus the name can't be changed for each build
- Rename output folders/filenames to match other team's approach
- Add linting via eslint & stylelint
- Perform linting & prettier via pre-commit git hook
peterkeating added a commit to EtchUK/Etch.OrchardCore.ThemeBoilerplate that referenced this pull request Oct 17, 2022
@peterkeating
Switch from webpack to Parcel
c86c4e4 
- Removed all webpack related configurations and dependencies
- Add parcel as dependency
- Moved static imagery to wwwroot as it's not longer moved as part of
the build process unless it's referenced directly in the CSS/TypeScript
- Needed to use `errorRecovery` option due to lightgallery using out of
date CSS techniques for clearfix - parcel-bundler/parcel#8352
- Removed content hashing using custom namer due to fonts being
preloaded in HTML, thus the name can't be changed for each build
- Rename output folders/filenames to match other team's approach
- Add linting via eslint & stylelint
- Perform linting & prettier via pre-commit git hook
@peterkeating peterkeating mentioned this pull request Oct 17, 2022
Merged
peterkeating added a commit to EtchUK/Etch.OrchardCore.ThemeBoilerplate that referenced this pull request Oct 17, 2022
@peterkeating
Switch from webpack to Parcel
ad72666 
- Removed all webpack related configurations and dependencies
- Add parcel as dependency
- Moved static imagery to wwwroot as it's not longer moved as part of
the build process unless it's referenced directly in the CSS/TypeScript
- Needed to use `errorRecovery` option due to lightgallery using out of
date CSS techniques for clearfix - parcel-bundler/parcel#8352
- Removed content hashing using custom namer due to fonts being
preloaded in HTML, thus the name can't be changed for each build
- Rename output folders/filenames to match other team's approach
- Add linting via eslint & stylelint
- Perform linting & prettier via pre-commit git hook
gorakong pushed a commit that referenced this pull request Nov 3, 2022
@lettertwo
Merge remote-tracking branch 'upstream/v2' into atlassian
1a45703 
* upstream/v2: (22 commits)
  Cross compile toolchains are built into docker image already
  Also fix release build
  Update centos node version
  v2.7.0
  Changelog for v2.7.0
  Use placeholder expression when replacing unused symbols (#8358)
  Lint (#8359)
  Add support for errorRecovery option in @parcel/transformer-css (#8352)
  VS Code Extension for Parcel (#8139)
  Add multi module compilation for elm (#8076)
  Bump terser from 5.7.2 to 5.14.2 (#8322)
  Bump node-forge from 1.2.1 to 1.3.0 (#8271)
  allow cjs config files on type module projects (#8253)
  inject script for hmr when there is only normal script in html (#8330)
  feat: support react refresh for @emotion/react (#8205)
  Update index.d.ts (#8293)
  remove charset from jsloader script set (#8346)
  Log resolved targets in verbose log level (#8254)
  Fix missing module in large app from Experimental Bundler (#8303)
  [Symbol Propagation] Non-deterministic bundle hashes (#8212)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devongovett @parcel-benchmark @mischnic