Fix SW packaging in web extensions #8424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR fixes the packaging of Service Workers using ES Modules in the
webextension
config.The JS transform does not support ES Modules for service workers:
parcel/packages/transformers/js/src/JSTransformer.js
Lines 575 to 577 in 3329469
Instead, it sets
outputFormat
toglobal
(docs). For that reason, thetype=module
is removed when packaging the extension.Related issue: #1747.
🚨 Test instructions
Here's a repo in which builds fail with
2.7.0
but pass with this PR:https://github.com/olistic/parcel-webextension-repro
✔️ PR Todo