Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clean): remove noRef helper because it is no longer needed for react-redux #20

Merged
merged 1 commit into from Sep 15, 2019

Conversation

pgarciacamou
Copy link
Owner

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Short description of what this PR does:

  • Removes noRef workaround from APIs

There are two solutions to work around this issue with react-redux.

  1. The first and most important is forwardRef option: https://react-redux.js.org/api/connect#forwardref-boolean.
  2. If this is not good enough, then wrapping is the best solution connect() does not work with React.forwardRef reduxjs/react-redux#914 (comment)

Either way, react-redux no longer has an issue with an object being passed as a component, in other words, it works with a component that uses forwardRef() as if you did not pass any references using .noRef(). Which is why I am removing this code.

@pgarciacamou pgarciacamou added the enhancement New feature or request label Sep 15, 2019
@pgarciacamou pgarciacamou self-assigned this Sep 15, 2019
@pgarciacamou pgarciacamou merged commit 9b6273e into master Sep 15, 2019
pgarciacamou added a commit that referenced this pull request May 22, 2020
feat(clean): remove noRef helper because it is no longer needed for react-redux
@pgarciacamou pgarciacamou deleted the remove-no-ref branch May 23, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant