Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CachingIterator::getCache stub. #1519

Merged
merged 2 commits into from Jul 18, 2022
Merged

Update CachingIterator::getCache stub. #1519

merged 2 commits into from Jul 18, 2022

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jul 18, 2022

This PR:

  • Fix CachingIterator::getCache stub

Relates to: vimeo/psalm#8282

Example: https://3v4l.org/i5faS#v8.1.8
On PHPStan playground: https://phpstan.org/r/1886cbba-060e-4fd8-bcd6-4ee5d273736f

@ondrejmirtes
Copy link
Member

Please use the playground link as a regression test in NodeScopeResolverTest here.

@ondrejmirtes ondrejmirtes merged commit d866a66 into phpstan:1.8.x Jul 18, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@drupol drupol deleted the stubs/update-CachingIterator-getCache branch July 18, 2022 16:03
drupol added a commit to loophp/iterators that referenced this pull request Jul 18, 2022
This issue will be fixed in PHPStan > 1.8.1.
See phpstan/phpstan-src#1519 for more info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants