ImagickPixel::getColor() normalized param accept int instead of bool #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankse
commented
Nov 21, 2022
mad-briller
reviewed
Nov 21, 2022
|
@VincentLanglet @rajyan I added the stub file. I think this should be enough right? |
|
apologies for my lack of reply @blankse github didn't notify me of your comment the first time
it's worth adding some NodeScopeResolverTest cases to prove that it's working as intended:
|
|
@mad-briller I added a test. |
|
You should also verify that https://phpstan.org/r/991c445c-3376-4892-947f-a1e5cd591d2d is actually fixed with CallMethodsRuleTest. Thank you. |
|
@ondrejmirtes I add a CallMethodsRuleTest for the params |
Co-authored-by: Brad Miller <28307684+mad-briller@users.noreply.github.com>
|
Thank you! |
kingjia90
added a commit
to pimcore/pimcore
that referenced
this pull request
Nov 28, 2022
3 tasks
fashxp
pushed a commit
to pimcore/pimcore
that referenced
this pull request
Nov 28, 2022
* Fix: pdfreactor buildPdf declaration not compatible with Abstract * Update Environment.php * Fix: clearEnv a nullable property should set it to `null` * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints Fixes for DataObjects * Update lib/Navigation/Renderer/Breadcrumbs.php Co-authored-by: Sebastian Blank <blank@data-factory.net> * Update bundles/EcommerceFrameworkBundle/src/Tracking/AbstractProductData.php Co-authored-by: Sebastian Blank <blank@data-factory.net> * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints getClass can return null * [Task]: Apply native parameter and return type hints * [Task]: Apply native parameter and return type hints * Task: remove getColor phpstan ignore it got fixed phpstan/phpstan-src#2020 * [Task]: Apply native parameter and return type hints Removed string check, but added string cast in Select.php * Revert "Task: remove getColor phpstan ignore it got fixed" This reverts commit 9651827. * Revert "Revert "Task: remove getColor phpstan ignore it got fixed"" This reverts commit 5f415a9. * [Task]: Apply native parameter and return type hints * [Task]: Apply native parameter and return type hints Set phpstan to fixed version instead of dev-branch * [Task]: Apply native parameter and return type hints Removed types for classId and className Co-authored-by: Marco Perberschlager <marco.perberschlager@pimcore.com> Co-authored-by: mcop1 <89011527+mcop1@users.noreply.github.com> Co-authored-by: Sebastian Blank <blank@data-factory.net>
brusch
pushed a commit
to pimcore/ecommerce-framework-bundle
that referenced
this pull request
Mar 28, 2023
* Fix: pdfreactor buildPdf declaration not compatible with Abstract * Update Environment.php * Fix: clearEnv a nullable property should set it to `null` * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints Fixes for DataObjects * Update lib/Navigation/Renderer/Breadcrumbs.php Co-authored-by: Sebastian Blank <blank@data-factory.net> * Update bundles/EcommerceFrameworkBundle/src/Tracking/AbstractProductData.php Co-authored-by: Sebastian Blank <blank@data-factory.net> * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints getClass can return null * [Task]: Apply native parameter and return type hints * [Task]: Apply native parameter and return type hints * Task: remove getColor phpstan ignore it got fixed phpstan/phpstan-src#2020 * [Task]: Apply native parameter and return type hints Removed string check, but added string cast in Select.php * Revert "Task: remove getColor phpstan ignore it got fixed" This reverts commit 965182793505c848b1db4586df2e462c0a29d7ee. * Revert "Revert "Task: remove getColor phpstan ignore it got fixed"" This reverts commit 5f415a9d576630ab58425ef964df6d2260551b6f. * [Task]: Apply native parameter and return type hints * [Task]: Apply native parameter and return type hints Set phpstan to fixed version instead of dev-branch * [Task]: Apply native parameter and return type hints Removed types for classId and className Co-authored-by: Marco Perberschlager <marco.perberschlager@pimcore.com> Co-authored-by: mcop1 <89011527+mcop1@users.noreply.github.com> Co-authored-by: Sebastian Blank <blank@data-factory.net>
brusch
pushed a commit
to pimcore/web-to-print-bundle
that referenced
this pull request
Apr 6, 2023
* Fix: pdfreactor buildPdf declaration not compatible with Abstract * Update Environment.php * Fix: clearEnv a nullable property should set it to `null` * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints Fixes for DataObjects * Update lib/Navigation/Renderer/Breadcrumbs.php Co-authored-by: Sebastian Blank <blank@data-factory.net> * Update bundles/EcommerceFrameworkBundle/src/Tracking/AbstractProductData.php Co-authored-by: Sebastian Blank <blank@data-factory.net> * [Task]: Apply native parameter and return type hints More return types and fixes added * [Task]: Apply native parameter and return type hints getClass can return null * [Task]: Apply native parameter and return type hints * [Task]: Apply native parameter and return type hints * Task: remove getColor phpstan ignore it got fixed phpstan/phpstan-src#2020 * [Task]: Apply native parameter and return type hints Removed string check, but added string cast in Select.php * Revert "Task: remove getColor phpstan ignore it got fixed" This reverts commit 965182793505c848b1db4586df2e462c0a29d7ee. * Revert "Revert "Task: remove getColor phpstan ignore it got fixed"" This reverts commit 5f415a9d576630ab58425ef964df6d2260551b6f. * [Task]: Apply native parameter and return type hints * [Task]: Apply native parameter and return type hints Set phpstan to fixed version instead of dev-branch * [Task]: Apply native parameter and return type hints Removed types for classId and className Co-authored-by: Marco Perberschlager <marco.perberschlager@pimcore.com> Co-authored-by: mcop1 <89011527+mcop1@users.noreply.github.com> Co-authored-by: Sebastian Blank <blank@data-factory.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be fix https://phpstan.org/r/991c445c-3376-4892-947f-a1e5cd591d2d
See PHP doc:
https://www.php.net/manual/en/imagickpixel.getcolor.php