Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Follow up native params and return type hints #13653

Merged
merged 21 commits into from Nov 28, 2022
Merged

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Nov 22, 2022

Follow-up #13474

@kingjia90 kingjia90 added this to the 11.0.0 milestone Nov 22, 2022
@github-actions
Copy link

Review Checklist

  • Target branch (10.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 added the Task label Nov 22, 2022
@kingjia90 kingjia90 marked this pull request as draft November 22, 2022 12:33
@mcop1 mcop1 linked an issue Nov 23, 2022 that may be closed by this pull request
@mcop1 mcop1 requested a review from fashxp November 28, 2022 08:55
@mcop1 mcop1 marked this pull request as ready for review November 28, 2022 09:01
models/Document/Editable/Select.php Outdated Show resolved Hide resolved
Removed string check, but added string cast in Select.php
Set phpstan to fixed version instead of dev-branch
Removed types for classId and className
@fashxp fashxp merged commit 0c20dd2 into 11.x Nov 28, 2022
@fashxp fashxp deleted the followup-13474 branch November 28, 2022 15:57
@fashxp fashxp mentioned this pull request Nov 29, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix possible errors after applying php native types
5 participants