New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] Follow up native params and return type hints #13653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
More return types and fixes added
More return types and fixes added
blankse
reviewed
Nov 23, 2022
Fixes for DataObjects
blankse
reviewed
Nov 24, 2022
Co-authored-by: Sebastian Blank <blank@data-factory.net>
…ata.php Co-authored-by: Sebastian Blank <blank@data-factory.net>
More return types and fixes added
getClass can return null
fashxp
requested changes
Nov 28, 2022
kingjia90
commented
Nov 28, 2022
Removed string check, but added string cast in Select.php
fashxp
approved these changes
Nov 28, 2022
dvesh3
reviewed
Nov 28, 2022
Set phpstan to fixed version instead of dev-branch
Removed types for classId and className
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #13474
pimcore/lib/Web2Print/Processor.php
Line 153 in 8d831ba
I see
useGuestCart
is nullable now, then it should benull
like the other properties as well when clearing, also this change would be missing after merging Remove Ecommerce override demo#376pimcore/lib/Image/Adapter/Imagick.php
Line 328 in 631a520