Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: fix empty result for cluster table when enable grpc compress #25513

Merged
merged 2 commits into from Jun 18, 2021
Merged

tikv: fix empty result for cluster table when enable grpc compress #25513

merged 2 commits into from Jun 18, 2021

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Jun 17, 2021 •
edited

What problem does this PR solve?

Issue Number: close #25419

Problem Summary:

go-grpc has some problem when enable compress with maxInt64 maxRecvMsgSize grpc/grpc-go#4552

this PR will fix on 5.1, master will using tikv/client-go#88

What is changed and how it works?

What's Changed, How it Works:

change maxRecvMsgSize to maxInt64-1

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test
try  #25419 and fixed after this patch

Side effects

  • n/a

Release note

  • No release note

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2021
@lysu lysu changed the title client: fix empty result for cluster table when enable grpc compress tikv: fix empty result for cluster table when enable grpc compress Jun 17, 2021
@lysu lysu requested review from cfzjywxk and crazycs520 June 17, 2021 06:35
@zhouqiang-cl zhouqiang-cl added backport-5.1.0 cherry-pick-approved Cherry pick PR approved by release team. labels Jun 17, 2021
@lysu
Copy link
Collaborator Author

lysu commented Jun 17, 2021

@cfzjywxk @crazycs520 PTAL

cfzjywxk
cfzjywxk approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

@cfzjywxk: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2021
jackysp
jackysp approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • jackysp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 18, 2021
@lysu
Copy link
Collaborator Author

lysu commented Jun 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 88f6421

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@ti-chi-bot ti-chi-bot merged commit 16c2bb5 into pingcap:release-5.1 Jun 18, 2021
@ti-srebot ti-srebot mentioned this pull request Jun 18, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #25557

@ti-srebot ti-srebot mentioned this pull request Jun 18, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25558

lysu added a commit to ti-srebot/tidb that referenced this pull request Jun 18, 2021
@lysu
cherry pick pingcap#25513 to release-5.0
26f50c5
lysu added a commit to ti-srebot/tidb that referenced this pull request Jun 18, 2021
@lysu
cherry pick pingcap#25513 to release-4.0
650cae4
ti-chi-bot pushed a commit that referenced this pull request Jul 7, 2021
@ti-srebot
tikv: fix empty result for cluster table when enable grpc compress (#…
53afe14 
…25513) (#25557)
ti-chi-bot pushed a commit that referenced this pull request Aug 30, 2021
@ti-srebot
tikv: fix empty result for cluster table when enable grpc compress (#…
83ddf67 
…25513) (#25558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@jackysp jackysp jackysp approved these changes

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-cherry-pick-release-5.0 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug. type/5.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lysu @ti-chi-bot @ti-srebot @cfzjywxk @jackysp @zhouqiang-cl