Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: fix empty result for cluster table when enable grpc compress (#25513) #25558

Merged
merged 3 commits into from Aug 30, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 18, 2021

cherry-pick #25513 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25558

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25558:release-5.0-16c2bb59a543

What problem does this PR solve?

Issue Number: close #25419

Problem Summary:

go-grpc has some problem when enable compress with maxInt64 maxRecvMsgSize grpc/grpc-go#4552

this PR will fix on 5.1, master will using tikv/client-go#88

What is changed and how it works?

What's Changed, How it Works:

change maxRecvMsgSize to maxInt64-1

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test
try  #25419 and fixed after this patch

Side effects

  • n/a

Release note

  • No release note

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added backport-5.1.0 cherry-pick-approved Cherry pick PR approved by release team. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.0-cherry-pick type/5.1-cherry-pick type/bug-fix This PR fixes a bug. labels Jun 18, 2021
@ti-chi-bot ti-chi-bot removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Jun 18, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 18, 2021
@ti-chi-bot ti-chi-bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2021
@ti-srebot
Copy link
Contributor Author

@lysu you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 18, 2021
@lysu lysu force-pushed the release-5.0-16c2bb59a543 branch from 10ea385 to 26f50c5 Compare June 18, 2021 06:15
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 18, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 18, 2021
@lysu lysu requested a review from wjhuang2016 August 23, 2021 10:21
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2021
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3ed5f74

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 30, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 83ddf67 into pingcap:release-5.0 Aug 30, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.2, v5.0.4 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants