Advance Timestamp when empty payload is packetized #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curently, the `Packetize` method has a sanity check that the payload being packetized is not of zero length; if is, then the function returns without doing anything. This interacts poorly with pion's binding to OpenH264, which simply returns payloads of zero length when `encode()` is called but a frame must be skipped for bandwidth limitation reasons. The most straightforward use of these two APIs with each other leads to a situation where an application reads an empty payload from OpenH264 and writes it into the Payloader directly. When this happens, the count of samples is not advanced, leading to incorrect timestamps in the generated RTP packets (which can cause A/V sync issues). This change simply ensures that the Packetizer Timestamp gets updated under such circumstances.
pionbot
force-pushed
the
packetizer-zero-length-fix
branch
from
81d731a
to
853b8fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 87.36% 87.31% -0.05%
==========================================
Files 18 18
Lines 1773 1774 +1
==========================================
Hits 1549 1549
- Misses 195 196 +1
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
Packetizemethod has a sanity check that the payloadbeing packetized is not of zero length; if is, then the function returns
without doing anything. This interacts poorly with pion's binding to
OpenH264, which simply returns payloads of zero length when
encode()is called but a frame must be skipped for bandwidth limitation reasons.
The most straightforward use of these two APIs with each other leads to
a situation where an application reads an empty payload from OpenH264
and writes it into the Payloader directly. When this happens, the count
of samples is not advanced, leading to incorrect timestamps in the
generated RTP packets (which can cause A/V sync issues). This change
simply ensures that the Packetizer Timestamp gets updated under such
circumstances.