Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advance Timestamp when empty payload is packetized #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Advance Timestamp when empty payload is packetized #192

wants to merge 1 commit into from

Commits on Jun 24, 2022

  1. Advance Timestamp when empty payload is packetized 

    Curently, the `Packetize` method has a sanity check that the payload
being packetized is not of zero length; if is, then the function returns
without doing anything. This interacts poorly with pion's binding to
OpenH264, which simply returns payloads of zero length when `encode()`
is called but a frame must be skipped for bandwidth limitation reasons.

The most straightforward use of these two APIs with each other leads to
a situation where an application reads an empty payload from OpenH264
and writes it into the Payloader directly. When this happens, the count
of samples is not advanced, leading to incorrect timestamps in the
generated RTP packets (which can cause A/V sync issues).  This change
simply ensures that the Packetizer Timestamp gets updated under such
circumstances.
    @adamroach
    adamroach committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    853b8fc View commit details
    Browse the repository at this point in the history