Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optional peer dependencies #1486

Closed
zkochan opened this issue Nov 13, 2018 · 8 comments · Fixed by #1788
Closed

Support optional peer dependencies #1486

zkochan opened this issue Nov 13, 2018 · 8 comments · Fixed by #1788
Labels
area: peers size: L type: feature
Milestone
v3.2

Comments

@zkochan
Copy link
Member

zkochan commented Nov 13, 2018 •
edited

As described in yarnpkg/rfcs#105
See also implementation in Yarn yarnpkg/yarn#6671

It is important to implement this before making independent-leaves true by default
@zkochan zkochan mentioned this issue Nov 13, 2018
Merged
@zkochan zkochan added this to the v3.0.0 milestone Dec 20, 2018
@ExE-Boss ExE-Boss mentioned this issue Dec 27, 2018
Open
@zkochan zkochan mentioned this issue Dec 27, 2018
Closed
This was referenced Jan 5, 2019
Closed
Closed
Closed
@zkochan zkochan added size: L and removed size: S labels Jan 5, 2019
@zkochan zkochan removed this from the v3.0.0 milestone Feb 4, 2019
@arcanis
Copy link

arcanis commented Feb 22, 2019

@zkochan not in the plans anymore?

@zkochan
Copy link
Member Author

zkochan commented Apr 7, 2019

@arcanis was it implemented in Yarn?

The RFC is in the "accepted" folder (not the "implemented" one). Also, there is no Yarn issue referenced from the RFC

@ExE-Boss
Copy link
Member

ExE-Boss commented Apr 8, 2019

Well, yarnpkg/yarn#6671 has been merged.

@arcanis
Copy link

arcanis commented Apr 8, 2019

Yep, it's implemented and shipped! I've also implemented it in the v2.

The rfc folders aren't super useful... It was a bad idea to have them in retrospect because moving files from one to the other breaks any link that's been made to the initial version 😕

@zkochan
Copy link
Member Author

zkochan commented Apr 8, 2019

I see. Yep, in that case we'll implement it in pnpm as well

@sodatea sodatea mentioned this issue Apr 16, 2019
Closed
@zkochan zkochan mentioned this issue Apr 22, 2019
Closed
@zkochan zkochan added this to the v3.2 milestone Apr 22, 2019
@arcanis
Copy link

arcanis commented Apr 23, 2019

For the record here's the documentation link for peerDependenciesMeta and its optional key:

https://yarnpkg.github.io/berry/configuration/manifest#peerDependenciesMeta

@zkochan
Copy link
Member Author

zkochan commented Apr 23, 2019 •
edited

Thank you! I will work on this soon. I will probably also add a --save-optional-peer flag as well

zkochan added a commit that referenced this issue Apr 23, 2019
@zkochan
feat: optional peer dependencies
0bc60a8 
close #1486
zkochan added a commit that referenced this issue Apr 23, 2019
@zkochan
feat: optional peer dependencies
a80381f 
close #1486
This was referenced Apr 23, 2019
Merged
Open
zkochan added a commit that referenced this issue Apr 24, 2019
@zkochan
feat: optional peer dependencies
c810e9a 
close #1486
@zkochan
Copy link
Member Author

zkochan commented Apr 24, 2019

🚢 3.2.0-1

This was referenced Oct 1, 2019
Closed
Merged
@dai-shi dai-shi mentioned this issue Oct 9, 2019
Open
@arcanis arcanis mentioned this issue Dec 12, 2019
Merged
@ylemkimon ylemkimon mentioned this issue Aug 7, 2020
Closed
@Andarist Andarist mentioned this issue Dec 15, 2022
Closed
@Ryan-Dia Ryan-Dia mentioned this issue Aug 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: peers size: L type: feature
Projects
None yet
Milestone
v3.2
Development

Successfully merging a pull request may close this issue.

feat: optional peer dependencies pnpm/pnpm
3 participants
@arcanis @zkochan @ExE-Boss