prepublishOnly was executed twice when publish

[VitorLuizC]

pnpm version: 5.9.3

Code to reproduce the issue:

pnpm publish -r

Expected behavior:

prepublishOnly of each package is executed once before publishing.

Actual behavior:

prepublishOnly of each package is executed twice before publishing.

Additional information:

• node -v prints: v14.14.0
• Windows, OS X, or Linux?: Windows with WSL (Ubuntu).

[PabloSzx]

any workaround to this?

@zkochan sorry for tagging, I could help to fix this if given some advice

[zkochan]

This code is in https://github.com/pnpm/pnpm/blob/main/packages/plugin-commands-publishing/src/recursivePublish.ts

if it executes twice, maybe npm publish ignores the --ignore-scripts option.

[PabloSzx]

npm/cli#2755 It seems to be an issue with npm 😞

[zkochan]

Indeed, this is a regression in npm v7. Use npm v6 for now.

[styfle]

I believe the issue might be related to pnpm pack running the prepublishOnly script when it should not

[rafaelliu]

@styfle is probably right, came here to file an issue about that. OP's issue is probably a consequence to prepublishOnly being executed during pack.

Here's what I'm seeing:

❯ pnpm pack

> mypkg@0.0.0 prepublishOnly <$PWD>
> echo prepublishOnly executed

prepublishOnly executed

> mypkg@0.0.0 prepack <$PWD>
> echo prepack executed

prepack executed
mypkg-0.0.0.tgz

[zkochan]

ok, it should be fixed.