New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression with version 7.4.0, it no longer update pnpm-lock.yaml
in CI due to recent PR to exit early on lockfile-only
#4951
Comments
I see, try |
yes it does seem to help at least now the unit tests that were failing with 7.4.0 are now passing in CI, is that what you suggest to use all the time? I won't close the issue just yet but I can test it out with a new |
It should work with no changes when I release this fix: #4955 |
oh that'd be great, do you have an ETA (estimated time) for a fix and new release of pnpm then? |
Probably in the next 24 hours. |
pnpm version:
7.4.0
Code to reproduce the issue:
see Lerna-Lite issue and it works fine with previous version 7.3.0. By looking at the recent PR #4932, which caused the regression, I found out that calling
--fix-lockfile
would make it work with the same behavior as before. Basically I used the fix lock file just because that seems to be the last flag I can use that is still in theif
condition that was modified recently by PR #4932pnpm/packages/core/src/install/index.ts
Lines 266 to 271 in 487527d
Expected behavior:
calling
pnpm install --lockfile-only
should work in CI and update lock file as it used to.Actual behavior:
since latest release 7.4.0 it no longer update
pnpm-lock.yaml
in CI due to recent PR to exit early onlockfile-only
Temporary fix:
For now I'm adding the fix lock to get around the regression problem but it's not a viable solution and I hope the regression is fix soon.
Additional information:
node -v
prints: allThe text was updated successfully, but these errors were encountered: