Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression with version 7.4.0, it no longer update pnpm-lock.yaml in CI due to recent PR to exit early on lockfile-only #4951

Closed
ghiscoding opened this issue Jun 29, 2022 · 5 comments · Fixed by #4955

Comments

@ghiscoding
Copy link

ghiscoding commented Jun 29, 2022

pnpm version:

7.4.0

Code to reproduce the issue:

see Lerna-Lite issue and it works fine with previous version 7.3.0. By looking at the recent PR #4932, which caused the regression, I found out that calling --fix-lockfile would make it work with the same behavior as before. Basically I used the fix lock file just because that seems to be the last flag I can use that is still in the if condition that was modified recently by PR #4932

if (
!ctx.lockfileHadConflicts &&
!opts.update &&
!opts.fixLockfile &&
installsOnly &&
(

Expected behavior:

calling pnpm install --lockfile-only should work in CI and update lock file as it used to.

Actual behavior:

since latest release 7.4.0 it no longer update pnpm-lock.yaml in CI due to recent PR to exit early on lockfile-only

Temporary fix:

For now I'm adding the fix lock to get around the regression problem but it's not a viable solution and I hope the regression is fix soon.

# temp fix to go around the regression
pnpm install --lockfile-only --fix-lockfile

Additional information:

  • node -v prints: all
  • Windows, macOS, or Linux?: all
@zkochan
Copy link
Member

zkochan commented Jun 30, 2022

I see, try pnpm install --lockfile-only --no-frozen-lockfile

@ghiscoding
Copy link
Author

ghiscoding commented Jun 30, 2022

yes it does seem to help at least now the unit tests that were failing with 7.4.0 are now passing in CI, is that what you suggest to use all the time? I won't close the issue just yet but I can test it out with a new version bump and release of Lerna-Lite itself since I use pnpm in it as well, I'll do that in the next couple of hours. It does seem promising at least

@zkochan
Copy link
Member

zkochan commented Jun 30, 2022

It should work with no changes when I release this fix: #4955

@ghiscoding
Copy link
Author

oh that'd be great, do you have an ETA (estimated time) for a fix and new release of pnpm then?

@zkochan
Copy link
Member

zkochan commented Jun 30, 2022

Probably in the next 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants