New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: --lockfile-only in CI and with frozen-lockfile=true #4955
Conversation
@@ -269,7 +269,7 @@ export async function mutateModules ( | |||
!opts.fixLockfile && | |||
installsOnly && | |||
( | |||
frozenLockfile || | |||
frozenLockfile && !opts.lockfileOnly || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that expected to be written without brackets ()
around it? I didn't test anything, I'm just asking. I mean should it be (frozenLockfile && !opts.lockfileOnly)
? If not then Prettier is probably to blame here, it's confusing when it's on 1 line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will work without brackets just fine. && has bigger priority than ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh ok I forgot about that, cool 👍🏻
close #4951