Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preferred versions in resolve dependencies #6737

Closed
zkochan opened this issue Jun 29, 2023 · 0 comments · Fixed by #6742
Closed

Fix preferred versions in resolve dependencies #6737

zkochan opened this issue Jun 29, 2023 · 0 comments · Fixed by #6742

Comments

@zkochan
Copy link
Member

zkochan commented Jun 29, 2023

about the possibility of overrides in preferredVersions, just noticed in code below(for both - before and after the pr), not sure if that can cause issues:

    if (!newPreferredVersions[resolvedPackage.name]) {
      newPreferredVersions[resolvedPackage.name] = {}
    }
    if (!newPreferredVersions[resolvedPackage.name][resolvedPackage.version]) {
      newPreferredVersions[resolvedPackage.name][resolvedPackage.version] = 'version'
      // ^^ -- here the content of `preferredVersions[resolvedPackage.name][resolvedPackage.version]` is possibly modified
      // that will happen if `resolvedPackage.name` was already in `preferredVersions` ()
    }

Originally posted by @zxbodya in #6735 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant