fix(resolve-dependencies): prefer versions found in parent packages only #6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxbodya
approved these changes
Jun 30, 2023
zxbodya
reviewed
Jun 30, 2023
Comment on lines
540
to
542
| if (newPreferredVersions[resolvedPackage.name] === preferredVersions[resolvedPackage.name]) { | ||
| newPreferredVersions[resolvedPackage.name] = { ...preferredVersions[resolvedPackage.name] } | ||
| } |
There was a problem hiding this comment.
alternative version:
if (!Object.prototype.hasOwnProperty.call(newPreferredVersions, resolvedPackage.name)) {
newPreferredVersions[resolvedPackage.name] = Object.create(preferredVersions[resolvedPackage.name])
}let me check if there is a difference in performance for this
zxbodya
reviewed
Jun 30, 2023
| @@ -537,6 +537,9 @@ export async function resolveDependencies ( | |||
| newPreferredVersions[resolvedPackage.name] = {} | |||
| } | |||
There was a problem hiding this comment.
instead of the change below, this can be replaced with
if (!Object.prototype.hasOwnProperty.call(newPreferredVersions, resolvedPackage.name)) {
newPreferredVersions[resolvedPackage.name] = preferredVersions[resolvedPackage.name]
? Object.create(preferredVersions[resolvedPackage.name])
: {}
}which is noticeably faster - 2m 50s vs 3m 16.8s for me
There was a problem hiding this comment.
But in npm-resolver we are then running Object.entries and Object.keys on newPreferredVersions[resolvedPackage.name], which will not list the properties if they were added with Object.create
There was a problem hiding this comment.
indeed that can be a problem, let's stick to safer option creating a copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6737