Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-reporter): remove file reporter #5012

Merged
merged 4 commits into from Jul 11, 2022

Conversation

william2958
Copy link
Contributor

Resolves issue #4949 where pnpm install will crash in a very large repository as the logs object in memory becomes too large for JSON.stringify to handle.

pnpm-lock.yaml Outdated
patchedDependencies:
pkg@5.7.0:
hash: pp6fkuhwkrqq7cjcj7uqpf37e4
path: patches/pkg@5.7.0.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you use the latest pnpm? The lockfile doesn't look right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems I was using a previous version of pnpm to install (7.1.7) but after upgrading to the latest version (7.5.0) & rerunning pnpm install, the pnpm-lock.yaml file is unchanged - is there something else I missed?

william2958 and others added 2 commits July 11, 2022 18:34
Co-authored-by: Zoltan Kochan <z@kochan.io>
Co-authored-by: Zoltan Kochan <z@kochan.io>
@zkochan zkochan enabled auto-merge (squash) July 11, 2022 22:44
@zkochan zkochan disabled auto-merge July 11, 2022 23:40
@zkochan zkochan merged commit c0b36bf into pnpm:main Jul 11, 2022
@welcome
Copy link

welcome bot commented Jul 11, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants