Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-reporter): remove file reporter #5012

Merged
merged 4 commits into from Jul 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rare-walls-smell.md
@@ -0,0 +1,5 @@
---
"pnpm": patch
---

Remove file reporter logging. Logged file is not useful [#4949](https://github.com/pnpm/pnpm/issues/4949).
4 changes: 0 additions & 4 deletions .github/ISSUE_TEMPLATE/bug-report.md
Expand Up @@ -18,10 +18,6 @@ assignees: ''

### Code to reproduce the issue:

<!--
If there was a fatal error also include a gist of your node_modules/.pnpm-debug.log file.
-->

### Expected behavior:

### Actual behavior:
Expand Down
17 changes: 0 additions & 17 deletions packages/file-reporter/CHANGELOG.md

This file was deleted.

15 changes: 0 additions & 15 deletions packages/file-reporter/README.md

This file was deleted.

6 changes: 0 additions & 6 deletions packages/file-reporter/jest.config.js

This file was deleted.

45 changes: 0 additions & 45 deletions packages/file-reporter/package.json

This file was deleted.

68 changes: 0 additions & 68 deletions packages/file-reporter/src/index.ts

This file was deleted.

2 changes: 0 additions & 2 deletions packages/file-reporter/test/fixture/1/.gitignore

This file was deleted.

12 changes: 0 additions & 12 deletions packages/file-reporter/test/fixture/1/index.js

This file was deleted.

Empty file.
2 changes: 0 additions & 2 deletions packages/file-reporter/test/fixture/1/stdin

This file was deleted.

7 changes: 0 additions & 7 deletions packages/file-reporter/test/fixture/1/stdout

This file was deleted.

12 changes: 0 additions & 12 deletions packages/file-reporter/test/fixture/2/index.js

This file was deleted.

1 change: 0 additions & 1 deletion packages/file-reporter/test/fixture/2/stdin

This file was deleted.

2 changes: 0 additions & 2 deletions packages/file-reporter/test/fixture/3/.gitignore

This file was deleted.

13 changes: 0 additions & 13 deletions packages/file-reporter/test/fixture/3/index.js

This file was deleted.

Empty file.
2 changes: 0 additions & 2 deletions packages/file-reporter/test/fixture/3/stdin

This file was deleted.

26 changes: 0 additions & 26 deletions packages/file-reporter/test/index.ts

This file was deleted.

12 changes: 0 additions & 12 deletions packages/file-reporter/tsconfig.json

This file was deleted.

8 changes: 0 additions & 8 deletions packages/file-reporter/tsconfig.lint.json

This file was deleted.

1 change: 0 additions & 1 deletion packages/pnpm/package.json
Expand Up @@ -30,7 +30,6 @@
"@pnpm/constants": "workspace:*",
"@pnpm/core-loggers": "workspace:*",
"@pnpm/default-reporter": "workspace:*",
"@pnpm/file-reporter": "workspace:*",
"@pnpm/filter-workspace-packages": "workspace:*",
"@pnpm/find-workspace-dir": "workspace:*",
"@pnpm/find-workspace-packages": "workspace:*",
Expand Down
4 changes: 0 additions & 4 deletions packages/pnpm/src/logging/fileLogger.ts

This file was deleted.

1 change: 0 additions & 1 deletion packages/pnpm/src/main.ts
Expand Up @@ -16,7 +16,6 @@ import chalk from 'chalk'
import checkForUpdates from './checkForUpdates'
import pnpmCmds, { rcOptionsTypes } from './cmd'
import { formatUnknownOptionsError } from './formatError'
import './logging/fileLogger'
import parseCliArgs from './parseCliArgs'
import initReporter, { ReporterType } from './reporter'
import isCI from 'is-ci'
Expand Down
2 changes: 0 additions & 2 deletions packages/pnpm/test/cli.ts
@@ -1,6 +1,5 @@
import { createReadStream, promises as fs, mkdirSync } from 'fs'
import path from 'path'
import pathExists from 'path-exists'
import PATH_NAME from 'path-name'
import prepare, { prepareEmpty } from '@pnpm/prepare'
import rimraf from '@zkochan/rimraf'
Expand Down Expand Up @@ -146,7 +145,6 @@ test('exit code from plugin is used to end the process', () => {

expect(result.status).toBe(1)
expect(result.stdout.toString()).toMatch(/is-positive/)
expect(pathExists.sync('node_modules/.pnpm-debug.log')).toBeFalsy()
})

const PNPM_CLI = path.join(__dirname, '../dist/pnpm.cjs')
Expand Down
10 changes: 0 additions & 10 deletions packages/pnpm/test/install/misc.ts
Expand Up @@ -36,16 +36,6 @@ test('bin files are found by lifecycle scripts', () => {
expect(result.stdout.toString()).toContain('Hello world!')
})

skipOnWindows('create a "node_modules/.pnpm-debug.log" file when the command fails', async () => {
prepare()

const result = execPnpmSync(['add', '@zkochan/i-do-not-exist'])

expect(result.status).toBe(1)

expect(await exists('.pnpm-debug.log')).toBeTruthy()
})

skipOnWindows('install --lockfile-only', async () => {
const project = prepare()

Expand Down
3 changes: 0 additions & 3 deletions packages/pnpm/tsconfig.json
Expand Up @@ -45,9 +45,6 @@
{
"path": "../default-reporter"
},
{
"path": "../file-reporter"
},
{
"path": "../filter-workspace-packages"
},
Expand Down