Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(env): show state on fetching node #5241

Merged
merged 3 commits into from Aug 22, 2022
Merged

feat(env): show state on fetching node #5241

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f65e5da
feat(env): show state on fetching node
JacobLinCool Aug 21, 2022
48b0984
fix: use internal logger instead of console.log
JacobLinCool Aug 22, 2022
7f63ad4
chore: add changeset
JacobLinCool Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/plugin-commands-env/package.json
View file
Open in desktop
Expand Up @@ -34,6 +34,7 @@
"@pnpm/config": "workspace:*",
"@pnpm/error": "workspace:*",
"@pnpm/fetch": "workspace:*",
"@pnpm/logger": "^4.0.0",
"@pnpm/node.fetcher": "workspace:*",
"@pnpm/node.resolver": "workspace:*",
"@pnpm/store-path": "workspace:*",
Expand Down
2 changes: 2 additions & 0 deletions packages/plugin-commands-env/src/node.ts
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@ import fs from 'fs'
import path from 'path'
import { Config } from '@pnpm/config'
import { createFetchFromRegistry, FetchFromRegistry } from '@pnpm/fetch'
import { globalInfo } from '@pnpm/logger'
import { fetchNode } from '@pnpm/node.fetcher'
import storePath from '@pnpm/store-path'
import loadJsonFile from 'load-json-file'
Expand Down Expand Up @@ -71,6 +72,7 @@ export async function getNodeDir (fetch: FetchFromRegistry, opts: NvmNodeCommand
pnpmHomeDir: opts.pnpmHomeDir,
})
const cafsDir = path.join(storeDir, 'files')
globalInfo(`Fetching Node.js ${opts.useNodeVersion} ...`)
await fetchNode(fetch, opts.useNodeVersion, versionDir, {
...opts,
cafsDir,
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.