feat(env): show state on fetching node #5241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
zkochan
reviewed
Aug 22, 2022
| @@ -71,6 +71,7 @@ export async function getNodeDir (fetch: FetchFromRegistry, opts: NvmNodeCommand | |||
| pnpmHomeDir: opts.pnpmHomeDir, | |||
| }) | |||
| const cafsDir = path.join(storeDir, 'files') | |||
| console.log(`Fetching Node.js ${opts.useNodeVersion} ...`) | |||
There was a problem hiding this comment.
you should probably import globalInfo from @pnpm/logger and print via it.
There was a problem hiding this comment.
Thanks for your friendly reminder! I was just curious to know why @pnpm/logger is out of the monorepo?
zkochan
approved these changes
Aug 22, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Aug 23, 2022
This was referenced Aug 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an immediate response when fetching Node.js on version switching, preventing pnpm looks like just hanging there.
I noticed that
@pnpm/loggerand@pnpm/core-loggersare being used in many packages.But it doesn't work when I try to use it like
logger.info({ message: "...", prefix: "dir" }), I think I have missed something.