Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(env): show state on fetching node #5241

Merged
merged 3 commits into from Aug 22, 2022
Merged

feat(env): show state on fetching node #5241

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f65e5da
feat(env): show state on fetching node
JacobLinCool Aug 21, 2022
48b0984
fix: use internal logger instead of console.log
JacobLinCool Aug 22, 2022
7f63ad4
chore: add changeset
JacobLinCool Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/plugin-commands-env/src/node.ts
View file
Open in desktop
Expand Up @@ -71,6 +71,7 @@ export async function getNodeDir (fetch: FetchFromRegistry, opts: NvmNodeCommand
pnpmHomeDir: opts.pnpmHomeDir,
})
const cafsDir = path.join(storeDir, 'files')
console.log(`Fetching Node.js ${opts.useNodeVersion} ...`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should probably import globalInfo from @pnpm/logger and print via it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your friendly reminder! I was just curious to know why @pnpm/logger is out of the monorepo?

await fetchNode(fetch, opts.useNodeVersion, versionDir, {
...opts,
cafsDir,
Expand Down