Fix: install peerDeps which is not optional on headless install #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 |
Shinyaigeek
commented
Aug 22, 2022
| "name": "reinstall-peer-deps", | ||
| "version": "1.0.0", | ||
| "devDependencies": { | ||
| "eslint-config-standard": "17.0.0" |
There was a problem hiding this comment.
I don’t have confidence about how to write dependencies for the test, so if there is a better way, I would be happy if you point it out.
There was a problem hiding this comment.
We use custom packages stored in https://github.com/pnpm/registry-mock for e2e. Those packages are small and faster to install, so tests are fast.
zkochan
reviewed
Aug 22, 2022
| @@ -162,7 +162,7 @@ function pkgAllDeps ( | |||
| ...(opts.include.optionalDependencies ? pkgSnapshot.optionalDependencies : {}), | |||
| }) | |||
| .map(([pkgName, ref]) => { | |||
| if (pkgSnapshot.peerDependencies?.[pkgName]) return null | |||
| if (pkgSnapshot.peerDependenciesMeta?.[pkgName]?.optional) return null | |||
There was a problem hiding this comment.
I honestly don't remember why this if statement is needed here. Maybe it should be removed.
zkochan
approved these changes
Aug 23, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This was referenced Aug 23, 2022
This was referenced Aug 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5213
I investigated #5213, and I found headless install, which is the faster installation way with lock file, skips to install peerDependencies. This is caused by this change. I looked up the change and infered that the change seems to be applied to skip to install optional dependencies but peerDependencies is also skipped. I think the ideal behavior is to skip only peerDependencies which is optional, so I fixed so.