Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: install peerDeps which is not optional on headless install #5243

Merged
merged 3 commits into from Aug 23, 2022
+63 −4
Merged

Fix: install peerDeps which is not optional on headless install #5243

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
516ecf9
fix: install peerDeps which is not optional on headless install
Shinyaigeek Aug 21, 2022
f6e2b7f
chore: add testcase for install peerDependencies which is not optional
Shinyaigeek Aug 21, 2022
d5dd8e1
refactor: auto install
zkochan Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/filter-lockfile/src/filterLockfileByImportersAndEngine.ts
View file
Open in desktop
Expand Up @@ -162,7 +162,7 @@ function pkgAllDeps (
...(opts.include.optionalDependencies ? pkgSnapshot.optionalDependencies : {}),
})
.map(([pkgName, ref]) => {
if (pkgSnapshot.peerDependencies?.[pkgName]) return null
if (pkgSnapshot.peerDependenciesMeta?.[pkgName]?.optional) return null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't remember why this if statement is needed here. Maybe it should be removed.

return dp.refToRelative(ref, pkgName)
})
.filter((nodeId) => nodeId !== null) as string[]
Expand Down
7 changes: 7 additions & 0 deletions packages/headless/test/fixtures/reinstall-peer-deps/package.json
View file
Open in desktop
@@ -0,0 +1,7 @@
{
"name": "reinstall-peer-deps",
"version": "1.0.0",
"devDependencies": {
"eslint-config-standard": "17.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have confidence about how to write dependencies for the test, so if there is a better way, I would be happy if you point it out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use custom packages stored in https://github.com/pnpm/registry-mock for e2e. Those packages are small and faster to install, so tests are fast.

}
}