Fix: test update command's handler correctly #5457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5410
currently,
update
command's test cannot verifyupdate
command becauseupdate
command works asrecursive
withworkspaceDir
anddir
args but current test implementation passes both ofworkspaceDir
anddir
args intoupdate
command's handler. FYI: https://github.com/pnpm/pnpm/blob/main/packages/plugin-commands-installation/src/installDeps.ts#L128-L130I fix this by removing
workspaceDir
args fromupdate
command's handler inupdate
test