Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: test update command's handler correctly #5457

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Fix: test update command's handler correctly #5457

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6105e7
chore: fix the update command's test case to test update command corr…
Shinyaigeek Oct 5, 2022
c9b1dcf
chore: add changeset
Shinyaigeek Oct 5, 2022
3964007
Revert "chore: add changeset"
Shinyaigeek Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 1 addition & 16 deletions packages/plugin-commands-installation/test/update/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,12 @@ test('update with "*" pattern', async () => {
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
workspaceDir: process.cwd(),
})

await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
workspaceDir: process.cwd(),
}, ['@pnpm.e2e/peer-*'])

const lockfile = await project.readLockfile()
Expand All @@ -56,14 +54,12 @@ test('update with negation pattern', async () => {
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
workspaceDir: process.cwd(),
})

await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
workspaceDir: process.cwd(),
}, ['!@pnpm.e2e/peer-*'])

const lockfile = await project.readLockfile()
Expand Down Expand Up @@ -114,7 +110,6 @@ describe('update by package name', () => {
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
workspaceDir: process.cwd(),
})
})
it("should fail when the package isn't in the direct dependencies and depth is 0", async () => {
Expand All @@ -125,20 +120,18 @@ describe('update by package name', () => {
depth: 0,
dir: process.cwd(),
sharedWorkspaceLockfile: true,
workspaceDir: process.cwd(),
}, ['@pnpm.e2e/peer-b'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_NO_PACKAGE_IN_DEPENDENCIES')
expect(err.message).toBe('None of the specified packages were found in the dependencies of any of the projects.')
expect(err.message).toBe('None of the specified packages were found in the dependencies.')
})
it("shouldn't fail when the package isn't in the direct dependencies", async () => {
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
sharedWorkspaceLockfile: true,
workspaceDir: process.cwd(),
}, ['@pnpm.e2e/peer-b'])
})
})
Expand All @@ -155,7 +148,6 @@ test('update --no-save should not update package.json and pnpm-lock.yaml', async
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
workspaceDir: process.cwd(),
})

{
Expand All @@ -174,7 +166,6 @@ test('update --no-save should not update package.json and pnpm-lock.yaml', async
dir: process.cwd(),
latest: true,
save: false,
workspaceDir: process.cwd(),
}, [])

{
Expand Down Expand Up @@ -206,14 +197,12 @@ test('update should work normal when set empty string version', async () => {
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
workspaceDir: process.cwd(),
})

await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
workspaceDir: process.cwd(),
}, ['*'])

const lockfile = await project.readLockfile()
Expand Down Expand Up @@ -246,7 +235,6 @@ test('ignore packages in package.json > updateConfig.ignoreDependencies fields i
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
workspaceDir: process.cwd(),
})

const lockfile = await project.readLockfile()
Expand All @@ -260,7 +248,6 @@ test('ignore packages in package.json > updateConfig.ignoreDependencies fields i
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
workspaceDir: process.cwd(),
latest: true,
})

Expand Down Expand Up @@ -291,7 +278,6 @@ test('not ignore packages if these are specified in parameter even if these are
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
workspaceDir: process.cwd(),
})

const lockfile = await project.readLockfile()
Expand All @@ -305,7 +291,6 @@ test('not ignore packages if these are specified in parameter even if these are
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
workspaceDir: process.cwd(),
}, ['@pnpm.e2e/foo@latest', '@pnpm.e2e/bar@latest'])

const lockfileUpdated = await project.readLockfile()
Expand Down