fix: only build git-hosted dependency if it has no main file #5868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
approved these changes
Jan 3, 2023
stefanmaric
added a commit
to MasterworksIO/eslint-config-masterworks
that referenced
this pull request
Jan 10, 2023
Version v7.20.0 of pnpm introduced a change that makes it run our publish script on install, breaking CI pipelines and local envs alike. See: pnpm/pnpm#5837 See: pnpm/pnpm#5826 See: https://github.com/pnpm/pnpm/releases/tag/v7.20.0 On environments where the pnpm store is cached, doing a second pnpm install solves the issue. These doesn't work in envs like Docker tho. Could be fixed by adding a `main` field to the top-level package.json as version v7.22.0 added a check for that. See: https://github.com/pnpm/pnpm/releases/tag/v7.22.0 See: pnpm/pnpm#5868 But since we are not really publishing these packages we can just remove the script. [f:2h]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5845