Fix architecture on ARM images #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Docker Hub hooks to set up build environment - Include qemu-static binaries for AMD64 compatibility
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
======================================
Coverage 86.2% 86.2%
======================================
Files 49 49
Lines 2894 2894
======================================
Hits 2495 2495
Misses 308 308
Partials 91 91 |
travisgroth
force-pushed
the
bug/arm-image-architecture
branch
from
5c66310
to
722fd0c
Compare
|
Code Climate has analyzed commit 722fd0c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.5% (0.0% change). View more on Code Climate. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered as part of #268. Doesn't fully resolve it, but is required to resolve it.
This PR changes our ARM Dockerfile builds to use alpine's ARM* base images (so that our architecture is correct) and uses qemu to do the final steps of the build, so that it can be built on any suitable AMD64 platform (such as Docker Hub's automated build system).
Checklist: