feat(crossplane-aws-factory): cleanup Kubernetes labels (#711)

* feat(crossplane-aws-factory): cleanup Kubernetes labels Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * feat(crossplane-ack-factory): bump chart version Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * fix(crossplane-aws-factory): typo Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> --------- Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
portefaix · Apr 17, 2024 · 21408ab · 21408ab
1 parent 508b96f
commit 21408ab
Show file tree

Hide file tree

Showing 16 changed files with 33 additions and 5 deletions.
diff --git a/charts/crossplane-aws-factory/Chart.yaml b/charts/crossplane-aws-factory/Chart.yaml
@@ -21,7 +21,7 @@ description: An AWS Factory using Crossplane
 home: https://github.com/portefaix/portefaix-hub/charts/crossplane-aws-factory
 icon: https://crossplane.io/images/favicon_192x192.png
 type: application
-version: 0.5.1
+version: 0.6.0
 appVersion: 1.0.0
 keywords:
   - cloud
@@ -53,4 +53,4 @@ annotations:
     url: https://keybase.io/nlamirault/pgp_keys.asc
   artifacthub.io/changes: |
     - kind: changed
-      description: Additional labels and annotations
+      description: Cleanup labels
diff --git a/charts/crossplane-aws-factory/templates/_helpers.tpl b/charts/crossplane-aws-factory/templates/_helpers.tpl
@@ -50,7 +50,6 @@ helm.sh/chart: {{ include "crossplane-aws-factory.chart" . }}
 {{- if .Chart.AppVersion }}
 app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
 {{- end }}
-app.kubernetes.io/component: crossplane-factory
 app.kubernetes.io/part-of: {{ include "crossplane-aws-factory.name" . }}
 app.kubernetes.io/managed-by: {{ .Release.Service }}
 crossplane.io/version: {{ .Values.crossplane.version }}

diff --git a/charts/crossplane-aws-factory/templates/aws-config.yaml b/charts/crossplane-aws-factory/templates/aws-config.yaml
@@ -22,6 +22,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: config
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/aws-controller-config.yaml b/charts/crossplane-aws-factory/templates/aws-controller-config.yaml
@@ -22,6 +22,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: config
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/aws-provider.yaml b/charts/crossplane-aws-factory/templates/aws-provider.yaml
@@ -22,6 +22,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: provider
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/ecr.yaml b/charts/crossplane-aws-factory/templates/ecr.yaml
@@ -27,6 +27,7 @@ metadata:
   namespace: {{ $namespace }}
   labels:
     {{- include "crossplane-aws-factory.labels" $ | nindent 4 }}
+    app.kubernetes.io/component: ecr
   {{- with $.Values.additionalAnnotations }}
   annotations:
   {{ toYaml . | indent 4 }}
@@ -49,6 +50,8 @@ kind: RepositoryPolicy
 metadata:
   name: {{ $repoName }}
   labels:
+    {{- include "crossplane-aws-factory.labels" $ | nindent 4 }}
+    app.kubernetes.io/component: ecr
     region: {{ $region }}
 spec:
   forProvider:
@@ -71,6 +74,9 @@ spec:
 apiVersion: ecr.aws.crossplane.io/v1alpha1
 kind: LifecyclePolicy
 metadata:
+  labels:
+    {{- include "crossplane-aws-factory.labels" $ | nindent 4 }}
+    app.kubernetes.io/component: ecr
   name: {{ $repoName }}
 spec:
   forProvider:

diff --git a/charts/crossplane-aws-factory/templates/eks.yaml b/charts/crossplane-aws-factory/templates/eks.yaml
@@ -22,6 +22,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: eks
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -67,6 +68,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: eks
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -110,6 +112,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: eks
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/iam-eks.yaml b/charts/crossplane-aws-factory/templates/iam-eks.yaml
@@ -22,6 +22,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: iam
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -69,6 +70,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: iam
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -113,6 +115,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: iam
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -135,6 +138,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: iam
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -157,6 +161,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: iam
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -179,6 +184,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: iam
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -201,6 +207,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: iam
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/internet-gateway.yaml b/charts/crossplane-aws-factory/templates/internet-gateway.yaml
@@ -22,6 +22,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: ec2
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -52,6 +53,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: ec2
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/nat-gateway.yaml b/charts/crossplane-aws-factory/templates/nat-gateway.yaml
@@ -22,6 +22,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: ec2
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -51,6 +52,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: ec2
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/sg.yaml b/charts/crossplane-aws-factory/templates/sg.yaml
@@ -22,6 +22,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: ec2
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}
@@ -56,6 +57,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: ec2
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/sns.yaml b/charts/crossplane-aws-factory/templates/sns.yaml
@@ -27,6 +27,7 @@ metadata:
   namespace: {{ $namespace }}
   labels:
     {{- include "crossplane-aws-factory.labels" $ | nindent 4 }}
+    app.kubernetes.io/component: sns
   {{- with $.Values.additionalAnnotations }}
   annotations:
   {{ toYaml . | indent 4 }}
@@ -56,6 +57,7 @@ metadata:
   namespace: {{ $namespace }}
   labels:
     {{- include "crossplane-aws-factory.labels" $ | nindent 4 }}
+    app.kubernetes.io/component: sns
   {{- with $.Values.additionalAnnotations }}
   annotations:
   {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/sqs.yaml b/charts/crossplane-aws-factory/templates/sqs.yaml
@@ -27,6 +27,7 @@ metadata:
   namespace: {{ $namespace }}
   labels:
     {{- include "crossplane-aws-factory.labels" $ | nindent 4 }}
+    app.kubernetes.io/component: sqs
   {{- with $.Values.additionalAnnotations }}
   annotations:
   {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/subnets.yaml b/charts/crossplane-aws-factory/templates/subnets.yaml
@@ -27,6 +27,7 @@ metadata:
   namespace: {{ $namespace }}
   labels:
     {{- include "crossplane-aws-factory.labels" $ | nindent 4 }}
+    app.kubernetes.io/component: ec2
 {{- with $.Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/templates/vpc.yaml b/charts/crossplane-aws-factory/templates/vpc.yaml
@@ -22,6 +22,7 @@ metadata:
   namespace: {{ template "crossplane-aws-factory.namespace" . }}
   labels:
     {{- include "crossplane-aws-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: ec2
 {{- with .Values.additionalAnnotations }}
   annotations:
 {{ toYaml . | indent 4 }}

diff --git a/charts/crossplane-aws-factory/values.yaml b/charts/crossplane-aws-factory/values.yaml
@@ -147,12 +147,11 @@ aws:
       - name: poc
         tags:
           Service: SNS
-    # -- SNS Subscriptions
+    # -- SNS Subscriptions
     subscriptions:
       - name: poc
         topicName: poc
         protocol: email
         endpoint: john.doe@gmail.com
         tags:
           Service: SNS
-