feat(ack-factory): cleanup Kubernetes labels (#709)

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
portefaix · Apr 16, 2024 · cc61aa1 · cc61aa1
1 parent 63aa431
commit cc61aa1
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 3 deletions.
diff --git a/charts/ack-factory/Chart.yaml b/charts/ack-factory/Chart.yaml
@@ -21,7 +21,7 @@ description: An AWS Factory using AWS Controllers for Kubernetes
 home: https://github.com/portefaix/portefaix-hub/charts/ack-factory
 icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
 type: application
-version: 0.3.0
+version: 0.4.0
 appVersion: 1.0.0
 keywords:
   - cloud
@@ -53,4 +53,4 @@ annotations:
   # added, changed, deprecated, removed, fixed and security.
   artifacthub.io/changes: |
     - kind: changed
-      description: Kubernetes v1.15 as default value for EKS
+      description: Cleanup labels
diff --git a/charts/ack-factory/templates/_helpers.tpl b/charts/ack-factory/templates/_helpers.tpl
@@ -50,7 +50,6 @@ helm.sh/chart: {{ include "ack-factory.chart" . }}
 {{- if .Chart.AppVersion }}
 app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
 {{- end }}
-app.kubernetes.io/component: krm-controller
 app.kubernetes.io/part-of: {{ include "ack-factory.name" . }}
 app.kubernetes.io/managed-by: {{ .Release.Service }} 
 {{- if .Values.additionalLabels }}

diff --git a/charts/ack-factory/templates/ecr.yaml b/charts/ack-factory/templates/ecr.yaml
@@ -28,6 +28,7 @@ metadata:
   {{- end }}
   labels:
     {{- include "ack-factory.labels" $ | nindent 4 }}
+    app.kubernetes.io/component: ecr
   name: {{ $repoName }}
   namespace: {{ $namespace }}
 spec:

diff --git a/charts/ack-factory/templates/eip.yaml b/charts/ack-factory/templates/eip.yaml
@@ -24,6 +24,7 @@ metadata:
   {{- end }}
   labels:
     {{- include "ack-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: ec2
   name: {{ include "ack-factory.name" . }}
   namespace: {{ template "ack-factory.namespace" . }}
 spec:

diff --git a/charts/ack-factory/templates/eks.yaml b/charts/ack-factory/templates/eks.yaml
@@ -24,6 +24,7 @@ metadata:
   {{- end }}
   labels:
     {{- include "ack-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: eks
   name: {{ include "ack-factory.name" . }}-eks-cluster
   namespace: {{ template "ack-factory.namespace" . }}
 spec:

diff --git a/charts/ack-factory/templates/gateways.yaml b/charts/ack-factory/templates/gateways.yaml
@@ -24,6 +24,7 @@ metadata:
   {{- end }}
   labels:
     {{- include "ack-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: ec2
   name: {{ include "ack-factory.name" . }}
   namespace: {{ template "ack-factory.namespace" . }}
 spec:

diff --git a/charts/ack-factory/templates/iam.yaml b/charts/ack-factory/templates/iam.yaml
@@ -24,6 +24,7 @@ metadata:
   {{- end }}
   labels:
     {{- include "ack-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: iam
   name: {{ include "ack-factory.name" . }}-eks-cluster
   namespace: {{ template "ack-factory.namespace" . }}
 spec:

diff --git a/charts/ack-factory/templates/s3.yaml b/charts/ack-factory/templates/s3.yaml
@@ -24,6 +24,7 @@ metadata:
   {{- end }}
   labels:
     {{- include "ack-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: s3
   name: {{ include "ack-factory.name" . }}
   namespace: {{ template "ack-factory.namespace" . }}
 spec:

diff --git a/charts/ack-factory/templates/sg.yaml b/charts/ack-factory/templates/sg.yaml
@@ -24,6 +24,7 @@ metadata:
   {{- end }}
   labels:
     {{- include "ack-factory.labels" . | nindent 4 }}
+    app.kubernetes.io/component: ec2
   name: {{ include "ack-factory.name" . }}-core
   namespace: {{ template "ack-factory.namespace" . }}
 spec:

diff --git a/charts/ack-factory/templates/subnets.yaml b/charts/ack-factory/templates/subnets.yaml
@@ -28,6 +28,7 @@ metadata:
   {{- end }}
   labels:
     {{- include "ack-factory.labels" $ | nindent 4 }}
+    app.kubernetes.io/component: ec2
   name: {{ $subnetName }}
   namespace: {{ $namespace }}
 spec:

diff --git a/charts/ack-factory/templates/vpc.yaml b/charts/ack-factory/templates/vpc.yaml
@@ -18,6 +18,9 @@
 apiVersion: ec2.services.k8s.aws/v1alpha1
 kind: VPC
 metadata:
+  labels:
+    {{- include "ack-factory.labels" $ | nindent 4 }}
+    app.kubernetes.io/component: ec2
   name: {{ include "ack-factory.name" . }}
 spec:
   cidrBlocks: