Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not rely on CI=true for TTY check #2639

Merged
merged 3 commits into from Apr 4, 2021
Merged

Not rely on CI=true for TTY check #2639

merged 3 commits into from Apr 4, 2021

Conversation

felipecrs
Copy link
Contributor

Fixes #2638

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #2639 (92ccf32) into develop (994a0e6) will increase coverage by 0.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2639      +/-   ##
===========================================
+ Coverage    90.85%   91.65%   +0.79%     
===========================================
  Files           21       21              
  Lines         1105     1102       -3     
  Branches       334      333       -1     
===========================================
+ Hits          1004     1010       +6     
+ Misses         101       92       -9     
Flag Coverage Δ
cli 82.39% <100.00%> (-0.05%) ⬇️
integration 42.37% <0.00%> (+0.11%) ⬆️
library 60.70% <0.00%> (+0.16%) ⬆️
unit 77.67% <100.00%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/reporters/cli/cli-utils.js 81.08% <100.00%> (-0.50%) ⬇️
bin/newman.js 89.79% <0.00%> (-0.41%) ⬇️
lib/print/index.js 98.27% <0.00%> (+15.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994a0e6...92ccf32. Read the comment docs.

lib/reporters/cli/cli-utils.js Outdated Show resolved Hide resolved
felipecrs and others added 2 commits March 28, 2021 12:50
Co-authored-by: Udit Vasu <codenirvana28@gmail.com>
@codenirvana codenirvana merged commit bb898b5 into postmanlabs:develop Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newman --color auto should give precedence to TERM over CI=true
3 participants