Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not rely on CI=true for TTY check #2639

Merged
merged 3 commits into from Apr 4, 2021
Merged

Not rely on CI=true for TTY check #2639

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bc58ba
Not rely on CI=true for TTY check
felipecrs Mar 2, 2021
2a40a43
Update lib/reporters/cli/cli-utils.js
felipecrs Mar 28, 2021
92ccf32
Update cli-utils.js
felipecrs Mar 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/reporters/cli/cli-utils.js
View file
Open in desktop
Expand Up @@ -93,14 +93,13 @@ cliUtils = {
* color: | noTTY:
* 'on' -> false
* 'off' -> true
* otherwise -> Based on CI or isTTY.
* otherwise -> Based on isatty.
*
* @param {String} color - A flag to indicate usage of the --color option.
* @returns {Boolean} - A boolean value depicting the result of the noTTY check.
*/
noTTY: function (color) {
return (color === 'off') || (color !== 'on') &&
(Boolean(process.env.CI) || !process.stdout.isTTY); // eslint-disable-line no-process-env
return (color === 'off') || (color !== 'on') && (!require('tty').isatty(1));
felipecrs marked this conversation as resolved.
Show resolved Hide resolved
},

/**
Expand Down