fix(glimmer): {{else}}{{#if}} into {{else if}} merging (#6080)

prettier · May 2, 2019 · 84cc273 · 84cc273
1 parent 157b020
commit 84cc273
Show file tree

Hide file tree

Showing 4 changed files with 124 additions and 2 deletions.
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -80,3 +80,37 @@ Examples:
     var x = (await foo.bar.blah)?.hi;
   }
   ```
+
+- Handlebars: Fix {{else}}{{#if}} into {{else if}} merging ([#6080] by [@dcyriller])
+
+  <!-- prettier-ignore -->
+  ```
+  // Input
+  {{#if a}}
+    a
+  {{else}}
+    {{#if c}}
+      c
+    {{/if}}
+    e
+  {{/if}}
+
+  // Output (Prettier stable)
+  {{#if a}}
+    a
+  {{else if c}}
+    c
+  e
+  {{/if}}
+
+  // Output (Prettier master)
+  Code Sample
+  {{#if a}}
+    a
+  {{else}}
+    {{#if c}}
+      c
+    {{/if}}
+    e
+  {{/if}}
+  ```
diff --git a/src/language-handlebars/printer-glimmer.js b/src/language-handlebars/printer-glimmer.js
@@ -106,11 +106,12 @@ function print(path, options, print) {
       const isElseIf =
         pp &&
         pp.inverse &&
+        pp.inverse.body.length === 1 &&
         pp.inverse.body[0] === n &&
         pp.inverse.body[0].path.parts[0] === "if";
       const hasElseIf =
         n.inverse &&
-        n.inverse.body[0] &&
+        n.inverse.body.length === 1 &&
         n.inverse.body[0].type === "BlockStatement" &&
         n.inverse.body[0].path.parts[0] === "if";
       const indentElse = hasElseIf ? a => a : indent;

diff --git a/tests/glimmer/__snapshots__/jsfmt.spec.js.snap b/tests/glimmer/__snapshots__/jsfmt.spec.js.snap
@@ -872,6 +872,22 @@ printWidth: 80
     ac
   {{/if}}
 {{/if}}
+
+{{#if a}}
+  a
+  <div>b</div>
+  c
+{{else}}
+  {{#if c}}
+    a
+    b
+    <div>c</div>
+  {{/if}}
+  <div>a</div>
+  b
+  c
+{{/if}}
+
 =====================================output=====================================
 {{#if a}}
   b
@@ -936,6 +952,26 @@ printWidth: 80
     ac
   {{/if}}
 {{/if}}
+{{#if a}}
+  a
+  <div>
+    b
+  </div>
+  c
+{{else}}
+  {{#if c}}
+    a
+    b
+    <div>
+      c
+    </div>
+  {{/if}}
+  <div>
+    a
+  </div>
+  b
+  c
+{{/if}}
 ================================================================================
 `;
 
@@ -1015,6 +1051,22 @@ singleQuote: true
     ac
   {{/if}}
 {{/if}}
+
+{{#if a}}
+  a
+  <div>b</div>
+  c
+{{else}}
+  {{#if c}}
+    a
+    b
+    <div>c</div>
+  {{/if}}
+  <div>a</div>
+  b
+  c
+{{/if}}
+
 =====================================output=====================================
 {{#if a}}
   b
@@ -1079,6 +1131,26 @@ singleQuote: true
     ac
   {{/if}}
 {{/if}}
+{{#if a}}
+  a
+  <div>
+    b
+  </div>
+  c
+{{else}}
+  {{#if c}}
+    a
+    b
+    <div>
+      c
+    </div>
+  {{/if}}
+  <div>
+    a
+  </div>
+  b
+  c
+{{/if}}
 ================================================================================
 `;
 

diff --git a/tests/glimmer/else-if.hbs b/tests/glimmer/else-if.hbs
@@ -66,4 +66,19 @@
   {{else if c}}
     ac
   {{/if}}
-{{/if}}
+{{/if}}
+
+{{#if a}}
+  a
+  <div>b</div>
+  c
+{{else}}
+  {{#if c}}
+    a
+    b
+    <div>c</div>
+  {{/if}}
+  <div>a</div>
+  b
+  c
+{{/if}}