Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies for ChainElements #15806

Merged
merged 16 commits into from Jan 3, 2024
Merged

Fix inconsistencies for ChainElements #15806

merged 16 commits into from Jan 3, 2024

Conversation

fisker
Copy link
Member

@fisker fisker commented Dec 15, 2023

Description

Fixes #15785

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker marked this pull request as ready for review December 15, 2023 09:21
@fisker
Copy link
Member Author

fisker commented Dec 15, 2023

Changes in prettier/prettier-regression-testing#342 (comment) are expected, since babel/babel-ts print them this way.

There should still be inconsistencies, we'll fix when user reported.

@fisker fisker merged commit ff9c083 into prettier:main Jan 3, 2024
28 checks passed
@fisker fisker deleted the 15785 branch January 3, 2024 03:11
medikoo pushed a commit to medikoo/prettier-elastic that referenced this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different output for optional call/member expression using typescript parser vs babel and babel-ts
2 participants