Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core-js support for build script #6866

Closed
wants to merge 6 commits into from

Conversation

fisker
Copy link
Member

@fisker fisker commented Nov 7, 2019

Since we've already drop Node 6 support for direct install from github, we could start using some new Syntax like async, Array.includes and more, at least for core bundles.

Also, some new version of dependencies requires async and Array#include, but our build script can't handle, like globby@10(#6776), cosmiconfig@6(#6850).

I add this as an option, and not enable for any bundle yet, also only allow to use for core bundles.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker changed the title Add core-js support for bundle Add core-js support for build script Nov 7, 2019
@lydell
Copy link
Member

lydell commented Nov 9, 2019

As far as I understand, we won’t need this in 2.0 so I’m closing. Let me know if I’ve misunderstood anything.

@lydell
Copy link
Member

lydell commented Nov 9, 2019

@fisker Feel free to continue discussion here. We’ll reopen if needed.

@fisker
Copy link
Member Author

fisker commented Nov 9, 2019

@lydell You are right, we can reopen it when we need it

@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2020
@fisker fisker deleted the corejs-support branch December 5, 2022 05:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants