TypeScript: Support a TS 3.9 breaking change for Optional Chaining and Non-Null Assertions #8450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
approved these changes
May 29, 2020
thorn0
reviewed
May 29, 2020
src/language-js/needs-parens.js
Outdated
| @@ -626,6 +626,14 @@ function needsParens(path, options) { | |||
|
|
|||
| case "OptionalMemberExpression": | |||
| case "OptionalCallExpression": | |||
| if ( | |||
| node.type === "OptionalMemberExpression" && | |||
There was a problem hiding this comment.
OptionalCallExpression should be handled too.
thorn0
reviewed
May 29, 2020
src/language-js/needs-parens.js
Outdated
| if ( | ||
| node.type === "OptionalMemberExpression" && | ||
| parent.type === "TSNonNullExpression" && | ||
| path.getParentNode(1).type === "MemberExpression" |
There was a problem hiding this comment.
Member expressions have two child nodes, so it's not enough to check only type here.
thorn0
reviewed
May 29, 2020
thorn0
approved these changes
May 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8339
changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨