Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove forceExit usage with jest #1897

Merged
merged 4 commits into from Jul 8, 2021
Merged

feat: Remove forceExit usage with jest #1897

merged 4 commits into from Jul 8, 2021

Conversation

janpio
Copy link
Member

@janpio janpio commented Jul 7, 2021 •
edited

This was referenced Jul 7, 2021
Closed
Closed
@janpio janpio marked this pull request as ready for review July 7, 2021 23:39
@janpio @millsp
Update test-runners/jest-with-multiple-generators/src/__tests__/the.t…
7d57070 
…est.ts

Co-authored-by: Pierre-Antoine Mills <pierreantoine.urvoy@gmail.com>
@janpio
Copy link
Member Author

janpio commented Jul 8, 2021

Added await for these $disconnect as well.

@janpio janpio merged commit 330ad50 into dev Jul 8, 2021
@janpio janpio deleted the janpio/no-forceexit branch July 8, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millsp millsp millsp approved these changes

@Jolg42 Jolg42 Jolg42 approved these changes

@williamluke4 williamluke4 Awaiting requested review from williamluke4

Assignees
No one assigned
Labels
topic: node-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate and remove usage of --forceExit
3 participants
@janpio @Jolg42 @millsp