Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate and remove usage of --forceExit #7795

Closed
6 tasks done
janpio opened this issue Jun 21, 2021 · 7 comments · Fixed by prisma/ecosystem-tests#1897 or #8482
Closed
6 tasks done

Investigate and remove usage of --forceExit #7795

janpio opened this issue Jun 21, 2021 · 7 comments · Fixed by prisma/ecosystem-tests#1897 or #8482
Assignees
@Jolg42
Labels
kind/tech A technical change. team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript. topic: node-api formerly `nApi` topic: tests
Milestone
2.29.0

Comments

@janpio
Copy link
Member

janpio commented Jun 21, 2021 •
edited by Jolg42

  • migrate
  • E2E
  • sdk
  • client
  • integration-tests
  • workflows

https://sourcegraph.com/search?q=context:global+repo:github.com/prisma/prisma+--forceExit+count:1000&patternType=literal
https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/prisma/e2e-tests%24+forceExit&patternType=literal

Especially if introduced for Node-API, this is something we should try to get rid of again before GA.
@janpio janpio added kind/tech A technical change. topic: node-api formerly `nApi` topic: tests team/client Issue for team Client. tech/typescript Issue for tech TypeScript. labels Jun 21, 2021
This was referenced Jun 25, 2021
Closed
Closed
@janpio
Copy link
Member Author

janpio commented Jun 25, 2021

Opened 2 PRs that show what is happening when you do this:
#7871
prisma/ecosystem-tests#1853

@janpio janpio self-assigned this Jun 25, 2021
@janpio
Copy link
Member Author

janpio commented Jun 25, 2021 •
edited

@janpio janpio removed their assignment Jun 25, 2021
@janpio janpio added process/candidate team/schema Issue for team Schema. labels Jun 25, 2021
@Jolg42 Jolg42 added this to the 2.27.0 milestone Jul 1, 2021
@millsp
Copy link
Member

millsp commented Jul 1, 2021 •
edited

Work has begun over here #7990

This was referenced Jul 1, 2021
Closed
Merged
@millsp
Copy link
Member

millsp commented Jul 7, 2021 •
edited

Still need to do this for migrate and E2E.

@janpio
Copy link
Member Author

janpio commented Jul 7, 2021 •
edited

Previous "work" on e2e: prisma/ecosystem-tests#1853

New PR for e2e: prisma/ecosystem-tests#1897

Jolg42 added a commit that referenced this issue Jul 7, 2021
@Jolg42
fix(db push): make sure to stop migrate engine when it errors
fdee7e9 
Related
#7795
#7990
@Jolg42 Jolg42 mentioned this issue Jul 7, 2021
Merged
@janpio janpio mentioned this issue Jul 7, 2021
Merged
@Jolg42 Jolg42 assigned Jolg42 and unassigned millsp Jul 8, 2021
@Jolg42 Jolg42 removed the team/client Issue for team Client. label Jul 8, 2021
@Jolg42
Copy link
Member

Jolg42 commented Jul 8, 2021

Reopening, still need to investigate something with migrate dev tests.

@Jolg42 Jolg42 reopened this Jul 8, 2021
Jolg42 added a commit that referenced this issue Jul 8, 2021
@Jolg42
fix(db push): make sure to stop migrate engine when it errors (#8149)
8898470 
* fix(db push): make sure to stop migrate engine when it errors

Related
#7795
#7990

* Restore package.json
@janpio
Copy link
Member Author

janpio commented Jul 8, 2021 •
edited

Node-API part done then 🙇‍♀️

@tomhoule tomhoule modified the milestones: 2.27.0, 2.28.0 Jul 15, 2021
@Jolg42 Jolg42 modified the milestones: 2.28.0, 2.29.0 Jul 28, 2021
@Jolg42 Jolg42 mentioned this issue Jul 28, 2021
Merged
Andrew-Colman pushed a commit to Andrew-Colman/prisma that referenced this issue Aug 7, 2021
@Jolg42 @Andrew-Colman
fix(db push): make sure to stop migrate engine when it errors (prisma…
c72c6f1 
…#8149)

* fix(db push): make sure to stop migrate engine when it errors

Related
prisma#7795
prisma#7990

* Restore package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
kind/tech A technical change. team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript. topic: node-api formerly `nApi` topic: tests
Projects
None yet
Milestone
2.29.0
4 participants
@janpio @Jolg42 @tomhoule @millsp