intro: Use the pair structure for models, field and indexes #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
intro/model-pairs
branch
6 times, most recently
from
6c54b49
to
25331c3
Compare
pimeys
commented
Dec 1, 2022
introspection-engine/connectors/sql-introspection-connector/src/sanitize_datamodel_names.rs
Outdated
Show resolved
Hide resolved
pimeys
force-pushed
the
intro/model-pairs
branch
from
25331c3
to
39c7a0d
Compare
pimeys
force-pushed
the
intro/model-pairs
branch
from
39c7a0d
to
8262ad5
Compare
tomhoule
approved these changes
Dec 2, 2022
| @@ -89,6 +91,11 @@ impl SqlSchema { | |||
| self.connector_data.data.as_ref().unwrap().downcast_ref().unwrap() | |||
| } | |||
|
|
|||
| /// The id of the next column | |||
| pub fn next_column_id(&self) -> ColumnId { | |||
There was a problem hiding this comment.
Leaving a comment here to come back to this later, I think this is a smell.
There was a problem hiding this comment.
discussed on zoom, we can change this later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: prisma/prisma#16546