Invalid db pull / db push flow

[janpio]

SQL:

CREATE TABLE `cm_linkprw` (
  `ID` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `video` enum('0','1') NOT NULL DEFAULT '0',
  PRIMARY KEY (`ID`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;

leads to invalid:

enum cm_linkprw_video {
  0 @map("0")
  1 @map("1")
}

so modified to:

enum cm_linkprw_video {
  is_false  @map("0")
  is_true   @map("1")
}

and adapted main model as well.

Problem is that another db pull changes that to this:

model cm_linkprw {
  ID          Int              @id @default(autoincrement()) @db.UnsignedInt
  postId      Int              @db.UnsignedInt
  url         String           @db.VarChar(150)
  video       cm_linkprw_video @default(dbgenerated("0"))
}

which when migrated then leads to:

Datasource "db": MySQL database "pabau" at "localhost:3307"
Error: Invalid default value for 'video'
   0: sql_migration_connector::apply_migration::apply_migration
             at migration-engine\connectors\sql-migration-connector\src\apply_migration.rs:9
   1: migration_core::state::SchemaPush
             at migration-engine\core\src\state.rs:347

error Command failed with exit code 1.

Changing the weird default back to:

video       cm_linkprw_video @default(is_false)

is undone on each db pull

[janpio]

The SQL of the migration is actually only invalid as there are single quotes missing when running db pull. This is valid and migrates correctly:

model cm_linkprw {
  ID    Int              @id @default(autoincrement()) @db.UnsignedInt
  video cm_linkprw_video @default(dbgenerated("'0'"))
}

enum cm_linkprw_video {
  is_false @map("0")
  is_true @map("1")
}

Follow up issue about this broken Introspection: #13754

[janpio]

I could still confirm the problem described in the issue (that the manually changed @default is undone again on db pull).

To the fix that was done in this PR (which I read as: "Keep valid renamed enum values as field defaults on Re-Introspection"), I think it is missing the warning message we usually add in these cases. When I run the recent dev for the above example, I get this only:

*** WARNING ***

These enum values were enriched with `@map` information taken from the previous Prisma schema.
- Enum "cm_linkprw_video"
- Enum "cm_linkprw_video"

I suggest we add another warning for the kept is_false value of cm_linkprw.video:

These fields of enum types were enriched with `@default` information taken from the previous Prisma schema:
- Field "cm_linkprw_video.video", value "is_false"

Or something like that.