Prisma Client (Binary): upgrade to undici@4

[janpio]

We have a long standing bug for the combination of Undici and Webpack: #6899 + #6564 Unfortunately there is no full workaround.

Undici@4 will most probably fix this, and we should upgrade to that as soon as possible.

To make sure this is possible, we should also try to upgrade to one of the recent release candidates as well and help them get that over the line, and make sure we have the necessary adaptations ready when the stable version is released.

[Jolg42]

Also related #6925

[Jolg42]

We should try to upgrade to the latest version, v4.0.0-rc.7 currently, see https://github.com/nodejs/undici/releases or https://github.com/nodejs/undici/tags

[janpio]

Obsolete as it is out now: #7705

[Jolg42]

blog post https://nodejs.medium.com/introducing-undici-4-1e321243e007

[Jolg42]

Note from undici v4 package.json the Node.js supported version is >=12.18
https://github.com/nodejs/undici/blob/main/package.json#L71-L73

Prisma supported version is >=12.2
https://www.prisma.io/docs/reference/system-requirements/

Node.js v12 releases https://nodejs.org/en/download/releases/

So it looks like we would need to bump Prisma to the same version?

[janpio]

Our tests should catch that 👍

[Jolg42]

I couldn't find why 2.18 was required maybe it's a choice and not an hard requirement.

Found this interesting bit for info
https://nodejs.org/en/blog/release/v12.18.0/

This is a security release.
Vulnerabilities fixed:

CVE-2020-8172: TLS session reuse can lead to host certificate verification bypass (High).
CVE-2020-11080: HTTP/2 Large Settings Frame DoS (Low).
CVE-2020-8174: napi_get_value_string_*() allows various kinds of memory corruption (High).

[millsp]

To investigate #7705 (comment)

[andrewgadziksonos]

Is there any update on this issue? Running into similar deployment issues in AWS Amplify (similar to this #8503)

[matthewmueller]

PR up: #7931

[matthewmueller]

Currently running into memory issues due to WASM being instatiated many times. Waiting for #8831.

[janpio]

If #8831 turns out to be fine, we still need to investigate the impact of the new files in the package and decide if we can/want/need to bundle them somehow instead. We also found a few weird bits where undici itself is bundled that way, which we should probably finish investigating (internal link: https://prisma-company.slack.com/archives/CUXLS0Z6K/p1629392329046500)

[Jolg42]

New PR is at #8842, tests are passing now.