fix(deps): update undici to 4.0.0 #7931
Conversation
|
|
| import { URL } from 'url' | ||
| export class Undici { | ||
| private pool: Pool | ||
| private closed = false | ||
| private url: string | URL |
There was a problem hiding this comment.
not sure about this one. unidici requires origin in Dispatcher.DispatchOptions even if it isn't required in their tests. I can remove this code and use type casting to Omit<Dispatcher.DispatchOptions, 'origin'> in this.pool.request() to fix that and get rid of this code.
michalkvasnicak
force-pushed
the
fix/update-undici
branch
from
cb39f50
to
fea217c
Compare
janpio
added
process/candidate
team/client
|
I unblocked the GH Actions run, so you should get test run feedback on this soon @michalkvasnicak |
| }), | ||
| // copy wasm files, etc necessary for undici | ||
| fs.copy( |
There was a problem hiding this comment.
I'm not familiar enough with esbuild. The problem is that undici uses path.resolve to establish a path to wasm files (https://github.com/nodejs/undici/blob/e705509ab22ab80aadf0fc1a394afff7dc014fdf/lib/client.js#L390-L398) and I wasn't able to find a plugin that could resolve that and copy files accordingly.
There was a problem hiding this comment.
I just don't know what I'm doing myself.
| @@ -51,7 +51,7 @@ | |||
| "new-github-issue-url": "^0.2.1", | |||
| "p-retry": "^4.2.0", | |||
| "terminal-link": "^2.1.1", | |||
| "undici": "3.3.6" | |||
| "undici": "^4.0.0" | |||
There was a problem hiding this comment.
I don't know why but pnpm also keeps the version 3.x.x which causes build of cli to fail if I remove _http_common from esbuild.external.
There was a problem hiding this comment.
also experiencing errors when _http_common is removed from Webpack's externals
|
We need to investigate whether |
|
https://media.giphy.com/media/GrUhLU9q3nyRG/source.gif |
|
Closing this in favor of #8842. Your contribution was included there. Thanks @michalkvasnicak! |
Closes #7539