chore(client, cli): implement --data-proxy [DPGA, 1] #13561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millsp
force-pushed
the
chore/data-proxy-ga-1
branch
from
ea8923b
to
d2ed17c
Compare
millsp
force-pushed
the
chore/data-proxy-ga-1
branch
from
d2ed17c
to
8c77b80
Compare
millsp
force-pushed
the
chore/data-proxy-ga-1
branch
from
3b025a7
to
400e01a
Compare
millsp
force-pushed
the
chore/data-proxy-ga-1
branch
2 times, most recently
from
2ba819c
to
53f6f82
Compare
millsp
force-pushed
the
chore/data-proxy-ga-1
branch
5 times, most recently
from
ca4e7c2
to
4926413
Compare
millsp
force-pushed
the
chore/data-proxy-ga-1
branch
from
4926413
to
d4e411a
Compare
millsp
changed the title
millsp
changed the title
millsp
requested review from
aqrln,
SevInf,
danstarns,
Jolg42 and
jkomyno
as code owners
millsp
commented
May 31, 2022
millsp
commented
May 31, 2022
millsp
commented
May 31, 2022
millsp
commented
May 31, 2022
millsp
commented
May 31, 2022
danstarns
reviewed
May 31, 2022
millsp
commented
May 31, 2022
packages/sdk/src/get-generators/utils/check-feature-flags/checkFeatureFlags.ts
Show resolved
Hide resolved
SevInf
reviewed
May 31, 2022
aqrln
reviewed
May 31, 2022
janpio
reviewed
May 31, 2022
janpio
reviewed
May 31, 2022
janpio
reviewed
May 31, 2022
janpio
approved these changes
May 31, 2022
janpio
changed the title
janpio
changed the title
janpio
changed the title
Co-authored-by: Alexey Orlenko <alex@aqrln.net>
14 tasks
aqrln
reviewed
Jun 3, 2022
aqrln
approved these changes
Jun 3, 2022
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> Co-authored-by: Alexey Orlenko <alex@aqrln.net>
jkomyno
reviewed
Jun 8, 2022
| > | ||
|
|
||
| // our implementation handles less | ||
| export type RequestOptions = O.Patch<{ headers?: { [k: string]: string }; body?: string }, RequestInit> |
There was a problem hiding this comment.
Note: it seems this change prevents TypeScript to properly build engine-core, as it affects the buildOptions function.
Temporary solution:
function buildOptions(options: RequestOptions): Https.RequestOptions {
return {
// @ts-ignore
method: options.method,
headers: buildHeaders(options),
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
PRISMA_CLIENT_ENGINE_TYPE=dataproxymechanism in favor of--data-proxyvia the cli.Next #13512
https://github.com/orgs/prisma/projects/70#card-82299232