feat(client): enable ITX support for DataProxy #15694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danstarns
requested review from
a team and
millsp
and removed request for
a team
danstarns
commented
Oct 7, 2022
millsp
reviewed
Oct 10, 2022
millsp
reviewed
Oct 10, 2022
aqrln
reviewed
Oct 11, 2022
millsp
reviewed
Oct 11, 2022
aqrln
changed the title
aqrln
reviewed
Oct 24, 2022
Comment on lines
+34
to
+36
| // TODO: temporary hack; we need to store url on the client itx proxy instead and pass it to the engine similar to id | ||
| // (probably some opaque `engineMeta: unknown` field and downcast it here to avoid leaking implementation details) | ||
| const txBaseUrls = new Map<string, string>() |
|
New PR for the integration branch: #16005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds DataProxy support for interactive transactions.
mini-proxy pr: https://github.com/prisma/mini-proxy/pull/36/files
internal doc: https://www.notion.so/prismaio/iTX-between-DP-and-the-Client-91c133e5b60d43dbbfa409fde2b430b3
How to run the tests?
Clone the branch and follow the instructions here to 'spin up' the mini-proxy.
Run the interactive transaction tests in this branch with: