New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): enable ITX support for DataProxy #16005
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
force-pushed
the
integration/itx-pdp
branch
from
November 7, 2022 14:08
c0b36ac
to
b1a481b
Compare
aqrln
requested review from
SevInf,
danstarns and
millsp
and removed request for
a team
November 7, 2022 20:14
aqrln
commented
Nov 8, 2022
aqrln
commented
Nov 8, 2022
aqrln
commented
Nov 8, 2022
danstarns
approved these changes
Nov 8, 2022
packages/engine-core/src/common/utils/runtimeHeadersToHttpHeaders.ts
Outdated
Show resolved
Hide resolved
SevInf
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments, suggestions, but nothing really blocking. Great job @aqrln and @danstarns!
packages/client/tests/functional/interactive-transactions/tests.ts
Outdated
Show resolved
Hide resolved
packages/engine-core/src/common/utils/runtimeHeadersToHttpHeaders.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Sergey Tatarintsev <tatarintsev@prisma.io>
…s.ts Co-authored-by: Sergey Tatarintsev <tatarintsev@prisma.io>
aqrln
force-pushed
the
integration/itx-pdp
branch
from
November 8, 2022 12:54
8ba05fa
to
6428634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR that supersedes #15694 because GitHub doesn't allow to change the branch for an existing PR, and we need integration releases for new commits here.
Original PR by @danstarns: #15694
Mini-Proxy PR: https://github.com/prisma/mini-proxy/pull/36
RFC (internal): https://www.notion.so/prismaio/iTX-between-DP-and-the-Client-91c133e5b60d43dbbfa409fde2b430b3
Tests for Data Proxy: https://github.com/prisma/itx-pdp-manual-tests
Closes https://github.com/prisma/client-planning/issues/92
Closes #16177