Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(client): add vitess flavor in relationMode test suite #16051

Merged
merged 15 commits into from Nov 2, 2022
Merged

test(client): add vitess flavor in relationMode test suite #16051

merged 15 commits into from Nov 2, 2022

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Oct 28, 2022 •
edited by Jolg42

This PR:

  • adds support for vitess-8 (using the Docker image vitess/vttestserver:mysql80)
  • introduces the concept of ProviderFlavor, a superset of Providers that allows distinguishing slightly different variants of providers. E.g., the vitess-8 flavor uses mysql as the provider in the Prisma schema, but its url is mapped to the TEST_FUNCTIONAL_VITESS_8_URI env variable rather than TEST_FUNCTIONAL_MYSQL_URI.

Note: I have noticed Vitess is particularly slow. Maybe there's something sketchy on my local machine and it's faster on the CI.

Related #6927.

@jkomyno jkomyno added this to the 4.6.0 milestone Oct 28, 2022
@jkomyno jkomyno marked this pull request as ready for review October 28, 2022 16:44
@jkomyno jkomyno requested a review from a team October 28, 2022 16:44
@jkomyno jkomyno requested a review from Jolg42 as a code owner October 28, 2022 16:44
@jkomyno jkomyno requested review from danstarns and removed request for a team October 28, 2022 16:44
Jolg42
Jolg42 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Note: only the relationMode tests are also tested on vitess.

@Jolg42 Jolg42 changed the title feat: test vitess flavor in relation mode suite test(client/relationMode): add vitess flavor in relatioMode test suite Oct 31, 2022
@Jolg42 Jolg42 changed the title test(client/relationMode): add vitess flavor in relatioMode test suite test(client): add vitess flavor in relationMode test suite Oct 31, 2022
@janpio
Copy link
Member

janpio commented Oct 31, 2022

Note: I have noticed Vitess is particularly slow. Maybe there's something sketchy on my local machine and it's faster on the CI.

What is the impact on CI/test run time?

@jkomyno
Copy link
Contributor Author

jkomyno commented Nov 2, 2022

Note: I have noticed Vitess is particularly slow. Maybe there's something sketchy on my local machine and it's faster on the CI.

What is the impact on CI/test run time?

You can see that CI / client-relationMode (prisma, ubuntu-latest, 16) got canceled after 35m. I will investigate ways of reducing the time needed for that.

Jolg42
Jolg42 reviewed Nov 2, 2022
View reviewed changes
docker/docker-compose.yml Outdated Show resolved Hide resolved
@jkomyno jkomyno mentioned this pull request Nov 2, 2022
Closed
janpio
janpio reviewed Nov 2, 2022
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
janpio
janpio reviewed Nov 2, 2022
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@Jolg42 Jolg42 merged commit 3f34330 into main Nov 2, 2022
@Jolg42 Jolg42 deleted the feat/test-vitess-flavor-relation-mode branch November 2, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

@Jolg42 Jolg42 Jolg42 approved these changes

@danstarns danstarns Awaiting requested review from danstarns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkomyno @janpio @Jolg42