Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(client): add vitess flavor in relationMode test suite #16051

Merged
merged 15 commits into from
Nov 2, 2022
Merged

test(client): add vitess flavor in relationMode test suite #16051

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
352ca7b
test: add providerFlavor=VITESS_8 support in relationMode tests
jkomyno Oct 28, 2022
d4e000e
chore(ci): add TEST_FUNCTIONAL_VITESS_8_URI to ci, add vitess-8 to do…
jkomyno Oct 28, 2022
0e4dc66
Merge branch 'main' into feat/test-vitess-flavor-relation-mode
jkomyno Oct 28, 2022
d6fe7bd
chore: improved comment
jkomyno Nov 2, 2022
aec66aa
chore(docker): attempt to speed up vitess
jkomyno Nov 2, 2022
fa4233f
Merge branch 'feat/test-vitess-flavor-relation-mode' of github.com:pr…
jkomyno Nov 2, 2022
791f353
ci: increase timeouts for relationMode tests due to slow Vitess provider
jkomyno Nov 2, 2022
18eb650
ci: allow 10gb of heap for Node.js in 'no-docker' workflow
jkomyno Nov 2, 2022
58bb2a1
Merge branch 'main' into feat/test-vitess-flavor-relation-mode
jkomyno Nov 2, 2022
fa6c4b0
ci: removed unneeded vitess-8 setup in 'client' workflow
jkomyno Nov 2, 2022
0f89642
ci: removed 'timeout-minutes' from individual tasks of 'client-relati…
jkomyno Nov 2, 2022
29be34f
chore(docker): removed env flags that tried to reduce Vitess slowness
jkomyno Nov 2, 2022
5c38cee
Merge branch 'feat/test-vitess-flavor-relation-mode' of github.com:pr…
jkomyno Nov 2, 2022
ed3891a
ci: remove vitess-8 support from 'client-dataproxy' workflow
jkomyno Nov 2, 2022
c9fb991
comment vitess 8 from buildkite
Jolg42 Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions docker/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,21 @@ services:
restart: always
ports:
- 33807:33807
healthcheck:
test: ['CMD', 'mysqladmin', 'ping', '-h127.0.0.1', '-P33577']
interval: 5s
timeout: 2s
retries: 5
start_period: 25s
environment:
PORT: '33804' # unused in testing, but required by vttestserver
KEYSPACES: 'keyspace' # unused in testing, but required by vttestserver
KEYSPACES: 'unsharded' # unused in testing, but required by vttestserver
NUM_SHARDS: '1' # unused in testing, but required by vttestserver

MYSQL_BIND_HOST: '0.0.0.0'
FOREIGN_KEY_MODE: 'disallow'
VT_DIALECT: 'mysql80'
PLANNER_VERSION: 'gen4fallback'
TOPOLOGY_FLAGS: '-shutdown_grace_period 2'
jkomyno marked this conversation as resolved.
Show resolved Hide resolved

# vitess-test-5_7:
# image: vitess/vttestserver:mysql57@sha256:2b132a22d08b3b227d9391f8f58ed7ab5c081ca07bf0f87a0c166729124d360a
Expand Down
4 changes: 3 additions & 1 deletion packages/client/tests/functional/_utils/relationMode/computeMatrix.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ export function computeMatrix({ relationMode, providersDenyList }: ComputeMatrix
const referentialActionsDenylistByProviderFlavor = {
foreignKeys: {
[Providers.SQLSERVER]: ['Restrict'],
[ProviderFlavors.VITESS_8]: referentialActionsBase, // no action is executed for Vitess & relationMode="foreignKeys"

// skip all actions for Vitess & relationMode="foreignKeys" as Foreign Keys are not supported by that provider
[ProviderFlavors.VITESS_8]: referentialActionsBase,
},
prisma: {
[Providers.SQLSERVER]: ['Restrict'],
Expand Down