Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internals): remove libquery_engine from npm package #16649

Merged
merged 2 commits into from Dec 6, 2022
Merged

fix(internals): remove libquery_engine from npm package #16649

merged 2 commits into from Dec 6, 2022

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Dec 6, 2022

Closes #15244
Related #14141

Before
https://www.npmjs.com/package/@prisma/internals Unpacked Size 124 MB

After, from pnpm publish --dry-run --no-git-checks
npm notice package size: 77.7 kB
npm notice unpacked size: 397.7 kB

@Jolg42
fix(internals): remove libquery_engine from npm package
1e83795 
Closes #15244
Related #14141

Before https://www.npmjs.com/package/@prisma/internals
Unpacked Size 124 MB

After, from `pnpm publish --dry-run --no-git-checks`
npm notice package size:  77.7 kB
npm notice unpacked size: 397.7 kB
@Jolg42 Jolg42 added this to the 4.8.0 milestone Dec 6, 2022
@Jolg42 Jolg42 requested a review from jkomyno as a code owner December 6, 2022 14:30
@Jolg42 Jolg42 requested review from a team and aqrln and removed request for a team December 6, 2022 14:30
@Jolg42 Jolg42 merged commit 8d68728 into main Dec 6, 2022
@Jolg42 Jolg42 deleted the joel/fix-internals-size branch December 6, 2022 17:26
@Jolg42
Copy link
Member Author

Jolg42 commented Dec 7, 2022

4.7.1

npm info @prisma/internals
dist
.tarball: https://registry.npmjs.org/@prisma/internals/-/internals-4.7.1.tgz
.shasum: 7eb4c08572b1f58fee1d9ddbc00119711542af90
.integrity: sha512-YgG+5zLZuKdVUPnNdw9XA0XGfW1vZaOqrcGgRnla0mSIIIB3Gg3noRuHv9ZQAXeHLWh2v7MHxal6fxKElMN0ug==
.unpackedSize: 124.4 MB

Released in internal dev 4.8.0-dev.24

npm info @prisma/internals@4.8.0-dev.24
dist
.tarball: https://registry.npmjs.org/@prisma/internals/-/internals-4.8.0-dev.24.tgz
.shasum: 1eaea98bfcc1702380beb41373c6ce459377d4d9
.integrity: sha512-1d7+CZnyqG2a5iXdJg1UD504MhPExzbeKvcU8Kqb/lePkyXV76ay2urzTpEjq2ZKHbune/GZq6PuXtsaY7gDrQ==
.unpackedSize: 395.4 kB

@Jolg42
Copy link
Member Author

Jolg42 commented Dec 7, 2022

And ecosystem-tests are passing, like expected
https://github.com/prisma/ecosystem-tests/actions/runs/3632197520
https://github.com/prisma/ecosystem-tests/actions/runs/3632197507

This was referenced Dec 7, 2022
Closed
Closed
Open
jkomyno pushed a commit that referenced this pull request Dec 21, 2022
@Jolg42 @jkomyno
fix(internals): remove libquery_engine from npm package (#16649)
a70ee48
jkomyno pushed a commit that referenced this pull request Dec 21, 2022
@Jolg42 @jkomyno
fix(internals): remove libquery_engine from npm package (#16649)
467439c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno jkomyno left review comments

@millsp millsp millsp approved these changes

@aqrln aqrln Awaiting requested review from aqrln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

Prisma 4.3.1 distribution is bundling a libquery_engine
3 participants
@Jolg42 @jkomyno @millsp